You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't fix a problem that makes zero sense to me (#18089), but in the interests of being a team player, I can try to contribute around the periphery.
This just takes the ext_data dict and a) standardizes the indentation, b) arranges the entries in alphabetical order. It is straightforward to check that the version of the dict here == the version in master. The main reason to do this is so that the diff in the next step is easy to review.
The next step is to go through and identify pyx files that don't cimport anything e.g. _libs.testing and fill out their ext_data entries with the appropriate []s (note that the processing of ext_data inserts default values for missing keys, so adding [] entries is part of the specification).
There are a few modules that meet that description, then a handful of others that only have cimports from numpy (e.g. io.sas._sas). Those entries can be fully filled out independently of any other outstanding issues.
@jreback : IMO we should just make sure that we get a deps list that works first and foremost. We can cut it down afterwards. I think that's why @jbrockmendel has been confused by what to do there.
1kastner
pushed a commit
to 1kastner/pandas
that referenced
this pull request
Nov 5, 2017
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gfyoung
changed the title
I can't fix a problem that makes zero sense to me (#18089), but in the interests of being a team player, I can try to contribute around the periphery.
This just takes the
ext_datadict and a) standardizes the indentation, b) arranges the entries in alphabetical order. It is straightforward to check that the version of the dict here==the version in master. The main reason to do this is so that the diff in the next step is easy to review.The next step is to go through and identify pyx files that don't cimport anything e.g.
_libs.testingand fill out theirext_dataentries with the appropriate[]s (note that the processing ofext_datainserts default values for missing keys, so adding[]entries is part of the specification).There are a few modules that meet that description, then a handful of others that only have cimports from numpy (e.g. io.sas._sas). Those entries can be fully filled out independently of any other outstanding issues.