-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: Standardize indentation and alphabetize deps #18104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this is fine (assume it lints ok) |
as far as the other issue |
Codecov Report
@@ Coverage Diff @@
## master #18104 +/- ##
==========================================
- Coverage 91.27% 91.26% -0.02%
==========================================
Files 163 163
Lines 50123 50123
==========================================
- Hits 45752 45744 -8
- Misses 4371 4379 +8
Continue to review full report at Codecov.
|
You're gonna have to be more specific. Or for the sake of morale, let me ignore this comment and move on with my day. |
@jreback : IMO we should just make sure that we get a deps list that works first and foremost. We can cut it down afterwards. I think that's why @jbrockmendel has been confused by what to do there. |
I can't fix a problem that makes zero sense to me (#18089), but in the interests of being a team player, I can try to contribute around the periphery.
This just takes the
ext_data
dict and a) standardizes the indentation, b) arranges the entries in alphabetical order. It is straightforward to check that the version of the dict here==
the version in master. The main reason to do this is so that the diff in the next step is easy to review.The next step is to go through and identify pyx files that don't cimport anything e.g.
_libs.testing
and fill out theirext_data
entries with the appropriate[]
s (note that the processing ofext_data
inserts default values for missing keys, so adding[]
entries is part of the specification).There are a few modules that meet that description, then a handful of others that only have cimports from numpy (e.g. io.sas._sas). Those entries can be fully filled out independently of any other outstanding issues.