Skip to content

fix error messages on import with broken build #18098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 3, 2017

There is some disagreement over whether this should close #18089, the canonical answer being "no". This at least makes it slightly less bad.

@jbrockmendel jbrockmendel changed the title fix error messages closes #18089 fix error messages <s>closes #18089</s> Nov 3, 2017
@jbrockmendel jbrockmendel changed the title fix error messages <s>closes #18089</s> fix error messages on import with broken build Nov 3, 2017
@gfyoung
Copy link
Member

gfyoung commented Nov 3, 2017

There is some disagreement over whether this should close #18089

No, there isn't any disagreement on our end. We're telling you that this message alone will not be sufficient and that even if this PR is merged, we will not close the issue.

@codecov
Copy link

codecov bot commented Nov 3, 2017

Codecov Report

Merging #18098 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18098      +/-   ##
==========================================
- Coverage   91.25%   91.23%   -0.02%     
==========================================
  Files         163      163              
  Lines       50120    50120              
==========================================
- Hits        45737    45728       -9     
- Misses       4383     4392       +9
Flag Coverage Δ
#multiple 89.04% <ø> (ø) ⬆️
#single 40.32% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/tests/indexes/timedeltas/__init__.py 92.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27bbea7...7c478d7. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 3, 2017

Codecov Report

Merging #18098 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18098      +/-   ##
==========================================
- Coverage   91.25%   91.23%   -0.02%     
==========================================
  Files         163      163              
  Lines       50120    50120              
==========================================
- Hits        45737    45728       -9     
- Misses       4383     4392       +9
Flag Coverage Δ
#multiple 89.04% <ø> (ø) ⬆️
#single 40.32% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/tests/indexes/timedeltas/__init__.py 92.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27bbea7...7c478d7. Read the comment docs.

@jbrockmendel
Copy link
Member Author

No, there isn't any disagreement on our end. We're telling you that this message alone will not be sufficient and that even if this PR is merged, we will not close the issue.

Buddy, no need to get snippy. See the original comment, I acknowledged that I don't get a vote in this.

@gfyoung
Copy link
Member

gfyoung commented Nov 4, 2017

Buddy, no need to get snippy. See the original comment, I acknowledged that I don't get a vote in this.

My bad if it came across that way. I was trying to make it clear that this wasn't really a point of contention, which is what your PR description made it sound like.

@jbrockmendel jbrockmendel deleted the build_deps branch December 8, 2017 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLD: tslib dependencies not fully specified
2 participants