-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
fix error messages on import with broken build #18098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No, there isn't any disagreement on our end. We're telling you that this message alone will not be sufficient and that even if this PR is merged, we will not close the issue. |
Codecov Report
@@ Coverage Diff @@
## master #18098 +/- ##
==========================================
- Coverage 91.25% 91.23% -0.02%
==========================================
Files 163 163
Lines 50120 50120
==========================================
- Hits 45737 45728 -9
- Misses 4383 4392 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18098 +/- ##
==========================================
- Coverage 91.25% 91.23% -0.02%
==========================================
Files 163 163
Lines 50120 50120
==========================================
- Hits 45737 45728 -9
- Misses 4383 4392 +9
Continue to review full report at Codecov.
|
Buddy, no need to get snippy. See the original comment, I acknowledged that I don't get a vote in this. |
My bad if it came across that way. I was trying to make it clear that this wasn't really a point of contention, which is what your PR description made it sound like. |
There is some disagreement over whether this should close #18089, the canonical answer being "no". This at least makes it slightly less bad.