ENH: improve output for testing.assert_*_equal with Categoricals #18069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
categorical_repr_in_testing
branch
from
cfd531f to
90f2aa4
Compare
jschendel
reviewed
Nov 2, 2017
pandas/util/testing.py
Outdated
| @@ -1074,8 +1074,12 @@ def assert_categorical_equal(left, right, check_dtype=True, | |||
| def raise_assert_detail(obj, message, left, right, diff=None): | |||
| if isinstance(left, np.ndarray): | |||
| left = pprint_thing(left) | |||
| elif pd.api.types.is_categorical_dtype(left): | |||
There was a problem hiding this comment.
Looks like is_categorical_dtype is already being imported from pandas.core.dtypes.common at the top of the file, so you should be able to just use is_categorical_dtype(left) here.
jschendel
reviewed
Nov 2, 2017
pandas/util/testing.py
Outdated
| if isinstance(right, np.ndarray): | ||
| right = pprint_thing(right) | ||
| elif pd.api.types.is_categorical_dtype(right): |
jschendel
reviewed
Nov 2, 2017
doc/source/whatsnew/v0.21.1.txt
Outdated
| @@ -117,7 +117,8 @@ Categorical | |||
| ^^^^^^^^^^^ | |||
|
|
|||
| - Bug in :meth:`DataFrame.astype` where casting to 'category' on an empty ``DataFrame`` causes a segmentation fault (:issue:`18004`) | |||
| - | |||
| - Error messages in the testing module have been improved when items have | |||
| different CategoricalDtype (:issue:`18069`) | |||
There was a problem hiding this comment.
Can you add backticks to ``CategoricalDtype``? Looks like that's what was typically done in the previous whatsnew.
topper-123
force-pushed
the
categorical_repr_in_testing
branch
from
90f2aa4 to
fde514e
Compare
Codecov Report
@@ Coverage Diff @@
## master #18069 +/- ##
==========================================
+ Coverage 91.25% 91.26% +<.01%
==========================================
Files 163 163
Lines 50120 50120
==========================================
+ Hits 45737 45740 +3
+ Misses 4383 4380 -3
Continue to review full report at Codecov.
|
|
Alright, I've adjusted according to comments from @jschendel. |
jreback
added
Categorical
|
thanks @topper-123 |
ghost
pushed a commit
to reef-technologies/pandas
that referenced
this pull request
Nov 3, 2017
1kastner
pushed a commit
to 1kastner/pandas
that referenced
this pull request
Nov 5, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Dec 8, 2017
(cherry picked from commit bb4fa65)
TomAugspurger
pushed a commit
that referenced
this pull request
Dec 11, 2017
(cherry picked from commit bb4fa65)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffThe new CategoricalDtype made the output from failing tests uninformative, see #18056.
The error message is now:
Which is much better.