Follow-Up To #17875 #18043
Merged
Follow-Up To #17875 #18043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so obviously you are linting these with some settings. pls add those to lint.sh if some files are not fixed, that is ok, just put them in a separate list with the current options. fixing things, but not changing the tests is ok, but doesn't prevent changes to these or help others. |
jreback
added
Code Style
|
Just amended the lint.sh file. Somehow this mental image comes to mind. |
|
@jbrockmendel hahah, great! |
|
One Travis env has a TestClipboard error, the other... I'm happy to clean these up, but doubt you want a giant sprawling PR. |
|
Reverted the lint.sh changes in the hopes of actually closing this out; opening a separate PR with the lint changes shortly. |
Codecov Report
@@ Coverage Diff @@
## master #18043 +/- ##
==========================================
+ Coverage 91.24% 91.25% +<.01%
==========================================
Files 163 163
Lines 50114 50114
==========================================
+ Hits 45729 45732 +3
+ Misses 4385 4382 -3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18043 +/- ##
==========================================
+ Coverage 91.24% 91.25% +<.01%
==========================================
Files 163 163
Lines 50114 50114
==========================================
+ Hits 45729 45732 +3
+ Misses 4385 4382 -3
Continue to review full report at Codecov.
|
|
this is fine, you can lint in the other PR. |
GuessWhoSamFoo
pushed a commit
to GuessWhoSamFoo/pandas
that referenced
this pull request
Nov 1, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 cleanup
use abbreviated dtstruct conversion functions
import from the cython versions of the stdlib instead of from src/datetime.pxd where possible.