Skip to content

ERR: Fix segfault with .astype('category') on empty DataFrame #18015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2017

Conversation

jschendel
Copy link
Member

Credit to @cgohlke for determining the fix.

@jreback jreback added Categorical Categorical Data Type Error Reporting Incorrect or improved errors from pandas labels Oct 28, 2017
@jreback jreback added this to the 0.21.1 milestone Oct 28, 2017
@jreback
Copy link
Contributor

jreback commented Oct 28, 2017

lgtm. ping on green.

if you are looking for things to work on #12860 is interesting.

@codecov
Copy link

codecov bot commented Oct 28, 2017

Codecov Report

Merging #18015 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18015      +/-   ##
==========================================
- Coverage   91.23%   91.22%   -0.02%     
==========================================
  Files         163      163              
  Lines       50091    50091              
==========================================
- Hits        45703    45695       -8     
- Misses       4388     4396       +8
Flag Coverage Δ
#multiple 89.03% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/io/pytables.py 92.84% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2d0d1b...b6745ae. Read the comment docs.

@jschendel
Copy link
Member Author

ping @jreback : green

Will look into the issue you referenced, seems interesting.

@jreback jreback added the Bug label Oct 29, 2017
@jreback jreback merged commit 5959ee3 into pandas-dev:master Oct 29, 2017
@jreback
Copy link
Contributor

jreback commented Oct 29, 2017

thanks @jschendel

@jschendel jschendel deleted the fix-category-segfault branch October 29, 2017 16:45
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 8, 2017
TomAugspurger pushed a commit that referenced this pull request Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Categorical Categorical Data Type Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERR: Segfault with df.astype(category) on empty dataframe
2 participants