Fix df.to_csv() for string arrays when encoded in utf-8 #18013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtkaleta
changed the title
gfyoung
added
IO CSV
jreback
requested changes
Oct 31, 2017
| str_array = [{'names': ['foo', 'bar']}, {'names': ['baz', 'qux']}] | ||
| df = pd.DataFrame(str_array) | ||
| expected_ascii = '''\ | ||
| ,names |
There was a problem hiding this comment.
so if you make this 2 test functions, then you can xfail the non-working one (to at least get things passing)
|
@jreback It seems the current behaviour stems from the fact that pandas' own >>> from pandas.io.formats.printing import pprint_thing
>>> pprint_thing([u'foo', u'bar'])
u'[foo, bar]'instead of the more intuitive (at least to me): >>> pprint_thing([u'foo', u'bar'], quote_strings=True)
u"[u'foo', u'bar']"A couple of questions come to mind:
|
Codecov Report
@@ Coverage Diff @@
## master #18013 +/- ##
==========================================
- Coverage 91.24% 91.24% -0.01%
==========================================
Files 163 163
Lines 50176 50124 -52
==========================================
- Hits 45785 45734 -51
+ Misses 4391 4390 -1
Continue to review full report at Codecov.
|
|
will have a look |
jreback
approved these changes
Nov 7, 2017
|
thanks @rtkaleta love for you to take a stab at fixing the xfailed unicode case! |
watercrossing
pushed a commit
to watercrossing/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it looks like
df.to_csv()is now working correctly for string arrays when using theasciiencoding but it is still broken when usingutf-8.