CLN: replace %s syntax /w .format in plotting, stats, tseries #18010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18010 +/- ##
==========================================
- Coverage 91.24% 91.22% -0.02%
==========================================
Files 163 163
Lines 50168 50168
==========================================
- Hits 45777 45768 -9
- Misses 4391 4400 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18010 +/- ##
==========================================
- Coverage 91.4% 89.21% -2.19%
==========================================
Files 163 163
Lines 50064 50064
==========================================
- Hits 45759 44665 -1094
- Misses 4305 5399 +1094
Continue to review full report at Codecov.
|
jreback
reviewed
Oct 28, 2017
pandas/_version.py
Outdated
| print(e) | ||
| return None | ||
| else: | ||
| if verbose: | ||
| print("unable to find command, tried %s" % (commands,)) | ||
| print("unable to find command, tried {commands}".format( | ||
| commands=commands,)) | ||
| return None | ||
| stdout = p.communicate()[0].strip() | ||
| if sys.version_info[0] >= 3: | ||
| stdout = stdout.decode() | ||
| if p.returncode != 0: | ||
| if verbose: |
There was a problem hiding this comment.
revert this file it is auto generated
There was a problem hiding this comment.
rather versioneer creates it; would rather use a newer versioneer
|
can u rebase |
jreback
requested changes
Nov 9, 2017
pandas/tseries/offsets.py
Outdated
| @@ -265,6 +265,22 @@ def _params(self): | |||
| params = tuple([str(self.__class__)] + attrs) | |||
| return params | |||
|
|
|||
| def __repr__(self): | |||
There was a problem hiding this comment.
remove this; its a rebase artifact
corazzon
changed the title
jreback
approved these changes
Nov 10, 2017
|
thanks! |
1 similar comment
|
thanks! |
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #16130
git diff upstream/master -u -- "*.py" | flake8 --diff