DOC:Cleaned up docstrings in sql.py #17967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
reviewed
Oct 24, 2017
pandas/io/sql.py
Outdated
| @@ -44,7 +44,7 @@ class DatabaseError(IOError): | |||
| def _validate_flavor_parameter(flavor): | |||
| """ | |||
| Checks whether a database 'flavor' was specified. | |||
| If not None, produces FutureWarning if 'sqlite' and | |||
| If not None, produces FutureWarning if 'SQLite' and | |||
There was a problem hiding this comment.
I think the previous version with lowercase 'sqlite' is correct, because this is referencing the flavor parameter that's being checked, and it's looking for all lowercase (see line 51).
There was a problem hiding this comment.
You are definitely correct. SQLite is the proper capitalization for the library when used as a noun in regular language, but it looks like it needs to be lower case when being implemented. Thanks for spotting that.
There was a problem hiding this comment.
Should be good now I believe.
|
needs a rebase |
|
@scotthavard92 Thanks! (fixed the conflict on merge) |
peterpanmj
pushed a commit
to peterpanmj/pandas
that referenced
this pull request
Oct 31, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidied up docstrings in pandas/io/sql.py.