flake8 cleanup

[jbrockmendel]

Entirely aesthetic.

• closes #xxxx
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[pep8speaks]

Hello @jbrockmendel! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on October 27, 2017 at 21:58 Hours UTC

[gfyoung]

Quick question(s): are we not style-checking this file in the first place? If not, why haven't we added it to the list of checked files?

[jbrockmendel]

IIUC its only the diffs that get checked in the CI, so existing flake8 errors pass through.

[gfyoung]

That's not the case, we should be linting the entire repository. However, I think it's because we only lint the pandas/pandas directory, and setup.py is not in that directory. Have a look at lint.sh and see if you can just add a line for that.

We ask that contributors lint the diff because that's what introduces style-check errors on a PR.

[codecov]

Codecov Report

Merging #17964 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17964      +/-   ##
==========================================
- Coverage   91.23%   91.22%   -0.02%     
==========================================
  Files         163      163              
  Lines       50113    50113              
==========================================
- Hits        45723    45714       -9     
- Misses       4390     4399       +9

Flag	Coverage Δ
#multiple	89.03% <ø> (ø)	⬆️
#single	40.31% <ø> (-0.06%)	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	25% <0%> (-58.34%)	⬇️
pandas/core/frame.py	97.75% <0%> (-0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1dabf3...bf35a27. Read the comment docs.

[codecov]

Codecov Report

Merging #17964 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17964      +/-   ##
==========================================
- Coverage   91.24%   91.23%   -0.02%     
==========================================
  Files         163      163              
  Lines       50168    50168              
==========================================
- Hits        45778    45769       -9     
- Misses       4390     4399       +9

Flag	Coverage Δ
#multiple	89.04% <ø> (ø)	⬆️
#single	40.27% <ø> (-0.06%)	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	25% <0%> (-58.34%)	⬇️
pandas/core/frame.py	97.75% <0%> (-0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff5109...0fadf75. Read the comment docs.

[jreback]

@gfyoung is right
this is fine if u also update lint.sh

all flake updates should update the checking code (eg for cython flaking)

[jbrockmendel]

OK, just added a clause in ci/lint.sh. I fully expect it to fail for the time being -- is there a mechanism to xfail?

[gfyoung]

@jbrockmendel : Not as far as I know. If you don't mind, why don't you try making a push to patch the remaining issues. If you have problems, remove the lint command from lint.sh, and we can pick it up from where you left off.

[jreback]

OK, just added a clause in ci/lint.sh. I fully expect it to fail for the time being -- is there a mechanism to xfail?

why would you expect a lint on this to fail? isn't that the point here, to make it work?

[jbrockmendel]

why would you expect a lint on this to fail? isn't that the point here, to make it work?

The original PR fixed some but not all of the issues. Following gfyoung's suggestion, I cleaned up the rest of it. So it should now pass.

[jreback]

@jbrockmendel yep looks good now.

[gfyoung]

@jreback : if this looks good to you, we can just merge this.

[jreback]

no merging until after the release (except specifically tagged pr)

[jreback]

even though this looks fine, can you rebase (as just added another cython module, indexing.pyx), maybe fine, but just want this to run and go green again.

[jreback]

thanks!