-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Removed references to v0.17 in docs and doc strings #17923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Removed references to v0.17 in docs and doc strings #17923
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17923 +/- ##
==========================================
- Coverage 91.26% 91.24% -0.02%
==========================================
Files 163 163
Lines 50099 50099
==========================================
- Hits 45724 45715 -9
- Misses 4375 4384 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Small typo comment, for the rest looks good! Although I would personally keep it for after 0.21.
doc/source/ecosystem.rst
Outdated
@@ -146,7 +146,10 @@ API | |||
|
|||
`pandas-datareader <https://github.com/pydata/pandas-datareader>`__ | |||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
``pandas-datareader`` is a remote data access library for pandas. ``pandas.io`` from pandas < 0.17.0 is now refactored/split-off to and importable from ``pandas_datareader`` (PyPI:``pandas-datareader``). Many/most of the supported APIs have at least a documentation paragraph in the `pandas-datareader docs <https://pandas-datareader.readthedocs.io/en/latest/>`_: | |||
``pandas-datareader`` is a remote data access library for pandas (PyPI:``pandas-datareader``). | |||
it is based on functionality that was located in ``pandas.io.data`` and ``pandas.io.wb`` but was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it -> It (capital)
@bkmrkr Please stopping spamming our github issues. As already noted to you twice before, you have to do this yourself. Follow the link to see this issue online on github, and at the top of that page you will see somewhere an "Unwatch" button, with which you can stop watching the pandas project. |
we can do this after 0.21 |
f6a5cab
to
8c85ab2
Compare
Ok to version later than V0.21. I've made the change requested by @jorisvandenbossche . In addition, I've found a reference to v.013 in |
can u rebase |
Also removes a reference to 0.13.
8c85ab2
to
e83d940
Compare
I've rebased. |
@topper-123 Thanks! |
Also removes a reference to 0.13.
Also removes a reference to 0.13.
git diff upstream/master -u -- "*.py" | flake8 --diff
This PR removes references to changes and "versionadded" for pandas v0.17. This can be considered a continuation to #17504.
I propose pulling this in as soon as 0.21 is released.
Alternatively, these could be accepted in v0.21, as these references to v0.17 IMO are too old to be useful to the average doc reader (approx. 2 years) and upgraders could just reference the 0.20 docs or the whatsnew sections of v0.21.