Skip to content

DOC: Removed references to v0.17 in docs and doc strings #17923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Oct 19, 2017

  • [ x] passes git diff upstream/master -u -- "*.py" | flake8 --diff

This PR removes references to changes and "versionadded" for pandas v0.17. This can be considered a continuation to #17504.

I propose pulling this in as soon as 0.21 is released.

Alternatively, these could be accepted in v0.21, as these references to v0.17 IMO are too old to be useful to the average doc reader (approx. 2 years) and upgraders could just reference the 0.20 docs or the whatsnew sections of v0.21.

@codecov
Copy link

codecov bot commented Oct 19, 2017

Codecov Report

Merging #17923 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17923      +/-   ##
==========================================
- Coverage   91.26%   91.24%   -0.02%     
==========================================
  Files         163      163              
  Lines       50099    50099              
==========================================
- Hits        45724    45715       -9     
- Misses       4375     4384       +9
Flag Coverage Δ
#multiple 89.05% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/plotting/_core.py 82.45% <ø> (ø) ⬆️
pandas/tseries/offsets.py 97.15% <ø> (ø) ⬆️
pandas/core/indexes/datetimelike.py 97.1% <ø> (ø) ⬆️
pandas/io/formats/style.py 100% <ø> (ø) ⬆️
pandas/core/indexes/base.py 96.42% <ø> (ø) ⬆️
pandas/core/indexes/timedeltas.py 91.19% <ø> (ø) ⬆️
pandas/io/sas/sas_xport.py 90.27% <ø> (ø) ⬆️
pandas/core/generic.py 92.42% <ø> (ø) ⬆️
pandas/core/indexes/datetimes.py 95.5% <ø> (ø) ⬆️
pandas/core/frame.py 97.75% <ø> (-0.1%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a355ed2...e83d940. Read the comment docs.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Small typo comment, for the rest looks good! Although I would personally keep it for after 0.21.

@@ -146,7 +146,10 @@ API

`pandas-datareader <https://github.com/pydata/pandas-datareader>`__
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
``pandas-datareader`` is a remote data access library for pandas. ``pandas.io`` from pandas < 0.17.0 is now refactored/split-off to and importable from ``pandas_datareader`` (PyPI:``pandas-datareader``). Many/most of the supported APIs have at least a documentation paragraph in the `pandas-datareader docs <https://pandas-datareader.readthedocs.io/en/latest/>`_:
``pandas-datareader`` is a remote data access library for pandas (PyPI:``pandas-datareader``).
it is based on functionality that was located in ``pandas.io.data`` and ``pandas.io.wb`` but was
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it -> It (capital)

@bkmrkr
Copy link

bkmrkr commented Oct 20, 2017 via email

@jorisvandenbossche
Copy link
Member

@bkmrkr Please stopping spamming our github issues. As already noted to you twice before, you have to do this yourself. Follow the link to see this issue online on github, and at the top of that page you will see somewhere an "Unwatch" button, with which you can stop watching the pandas project.

@jreback jreback added the Docs label Oct 20, 2017
@jreback
Copy link
Contributor

jreback commented Oct 20, 2017

we can do this after 0.21

@topper-123
Copy link
Contributor Author

topper-123 commented Oct 20, 2017

Ok to version later than V0.21.

I've made the change requested by @jorisvandenbossche .

In addition, I've found a reference to v.013 in io.rst that I think should be removed, could you take a look at that (maybe it's talking about changes later than c0.13 also; in that case the text should be made more explicit).

@jreback jreback added this to the 0.22.0 milestone Oct 27, 2017
@jreback
Copy link
Contributor

jreback commented Oct 27, 2017

can u rebase

Also removes a reference to 0.13.
@topper-123
Copy link
Contributor Author

I've rebased.

@jorisvandenbossche jorisvandenbossche merged commit 3f4089d into pandas-dev:master Oct 30, 2017
@jorisvandenbossche
Copy link
Member

@topper-123 Thanks!

peterpanmj pushed a commit to peterpanmj/pandas that referenced this pull request Oct 31, 2017
@topper-123 topper-123 deleted the remove_0.17_refs branch November 6, 2017 21:46
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants