BUG: support "fill_value" for ".unstack()" called with list of levels #17887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toobaz
force-pushed
the
unstack_multi
branch
3 times, most recently
from
65171d9 to
2d56672
Compare
Codecov Report
@@ Coverage Diff @@
## master #17887 +/- ##
==========================================
- Coverage 91.23% 91.21% -0.02%
==========================================
Files 163 163
Lines 50102 50102
==========================================
- Hits 45712 45703 -9
- Misses 4390 4399 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17887 +/- ##
==========================================
+ Coverage 91.23% 91.24% +<.01%
==========================================
Files 163 163
Lines 50105 50105
==========================================
+ Hits 45714 45718 +4
+ Misses 4391 4387 -4
Continue to review full report at Codecov.
|
jreback
requested changes
Oct 16, 2017
pandas/tests/frame/test_reshape.py
Outdated
| expected = unstacked[key] | ||
| result = pd.Series([0, 0, 2], index=unstacked.index, name=key) | ||
| assert_series_equal(result, expected) | ||
| stacked = unstacked.stack(['x', 'y']) |
There was a problem hiding this comment.
put blank lines between cases
pandas/tests/frame/test_reshape.py
Outdated
| assert_series_equal(result, expected) | ||
| stacked = unstacked.stack(['x', 'y']) | ||
| stacked.index = stacked.index.reorder_levels(f.index.names) | ||
| # Workaround for GH #17886: |
There was a problem hiding this comment.
add a comment here on why (in addition to the issue number)
jreback
reviewed
Oct 16, 2017
pandas/tests/frame/test_reshape.py
Outdated
| @@ -154,6 +154,29 @@ def test_unstack_fill(self): | |||
| index=['x', 'y', 'z'], dtype=np.float) | |||
| assert_frame_equal(result, expected) | |||
|
|
|||
| # GH #13971: fill_value when unstacking multiple levels: | |||
| f = DataFrame({'x': ['a', 'a', 'b'], | |||
jreback
added
Missing-data
|
lgtm minor comments. |
jreback
approved these changes
Oct 16, 2017
|
thanks @toobaz |
dmanikowski-reef
pushed a commit
to reef-technologies/pandas
that referenced
this pull request
Oct 16, 2017
yeemey
pushed a commit
to yeemey/pandas
that referenced
this pull request
Oct 20, 2017
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffNotice this is a simple fix which doesn't make @kordek 's more general comment about the opportunity for refactoring less valid.