Skip to content

DOC: Adding examples to update docstring (#16812) #17859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2017
Merged

DOC: Adding examples to update docstring (#16812) #17859

merged 3 commits into from
Oct 16, 2017

Conversation

reidy-p
Copy link
Contributor

@reidy-p reidy-p commented Oct 12, 2017

@pep8speaks
Copy link

pep8speaks commented Oct 12, 2017 •
edited
Loading

Hello @reidy-p! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on October 13, 2017 at 20:20 Hours UTC

jorisvandenbossche
jorisvandenbossche reviewed Oct 13, 2017
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reidy-p Thanks for the PR!

General comment: IMO updating an integer column with strings is not a very typical applications (or not one we should advertise in the docs I think). I would rather give an example where you update an integer column with integers / string column with strings.

Maybe you can also show the effect of aligning on the index by updating with a frame that has not the same number of rows (specify the index manually in the construction)

@reidy-p
Copy link
Contributor Author

reidy-p commented Oct 13, 2017

@jorisvandenbossche thanks for the feedback! I'll update the PR.

@codecov
Copy link

codecov bot commented Oct 13, 2017

Codecov Report

Merging #17859 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17859      +/-   ##
==========================================
- Coverage   91.23%   91.21%   -0.02%     
==========================================
  Files         163      163              
  Lines       50069    50069              
==========================================
- Hits        45678    45669       -9     
- Misses       4391     4400       +9
Flag Coverage Δ
#multiple 89.02% <ø> (ø) ⬆️
#single 40.26% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/frame.py 97.75% <ø> (-0.1%) ⬇️
pandas/core/series.py 94.99% <ø> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92db5c9...6e8fd90. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 13, 2017 •
edited
Loading

Codecov Report

Merging #17859 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17859      +/-   ##
==========================================
- Coverage   91.23%   91.22%   -0.01%     
==========================================
  Files         163      163              
  Lines       50069    50075       +6     
==========================================
+ Hits        45678    45679       +1     
- Misses       4391     4396       +5
Flag Coverage Δ
#multiple 89.03% <ø> (ø) ⬆️
#single 40.29% <ø> (-0.03%) ⬇️
Impacted Files Coverage Δ
pandas/core/frame.py 97.75% <ø> (-0.1%) ⬇️
pandas/core/series.py 94.99% <ø> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/groupby.py 91.98% <0%> (-0.02%) ⬇️
pandas/core/panel.py 96.96% <0%> (-0.01%) ⬇️
pandas/core/indexes/base.py 96.47% <0%> (-0.01%) ⬇️
pandas/core/window.py 96.37% <0%> (ø) ⬆️
pandas/core/indexes/multi.py 96.39% <0%> (ø) ⬆️
pandas/core/generic.py 92.2% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92db5c9...6e8fd90. Read the comment docs.

@jreback jreback added this to the 0.21.0 milestone Oct 14, 2017
@jreback
Copy link
Contributor

jreback commented Oct 14, 2017

lgtm. @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche merged commit 00f23ca into pandas-dev:master Oct 16, 2017
@jorisvandenbossche
Copy link
Member

@reidy-p Thanks!

ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
@reidy-p
DOC: Adding examples to update docstring (pandas-dev#16812) (pandas-d…
d4f9453 
…ev#17859)

* DOC: Adding examples to update docstring (pandas-dev#16812)

* formatting issues

* improving examples
ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
Merge remote-tracking branch 'upstream/master'
ff32d61 
* upstream/master: (76 commits)
  CategoricalDtype construction: actually use fastpath (pandas-dev#17891)
  DEPR: Deprecate tupleize_cols in to_csv (pandas-dev#17877)
  BUG: Fix wrong column selection in drop_duplicates when duplicate column names (pandas-dev#17879)
  DOC: Adding examples to update docstring (pandas-dev#16812) (pandas-dev#17859)
  TST: Skip if no openpyxl in test_excel (pandas-dev#17883)
  TST: Catch read_html slow test warning (pandas-dev#17874)
  flake8 cleanup (pandas-dev#17873)
  TST: remove moar warnings (pandas-dev#17872)
  ENH: tolerance now takes list-like argument for reindex and get_indexer. (pandas-dev#17367)
  ERR: Raise ValueError when week is passed in to_datetime format witho… (pandas-dev#17819)
  TST: remove some deprecation warnings (pandas-dev#17870)
  Refactor index-as-string groupby tests and fix spurious warning (Bug 17383) (pandas-dev#17843)
  BUG: merging with a boolean/int categorical column (pandas-dev#17841)
  DEPR: Deprecate read_csv arguments fully (pandas-dev#17865)
  BUG: to_json - prevent various segfault conditions (GH14256) (pandas-dev#17857)
  CLN: Use pandas.core.common for None checks (pandas-dev#17816)
  BUG: set tz on DTI from fixed format HDFStore (pandas-dev#17844)
  RLS: v0.21.0rc1
  Whatsnew cleanup (pandas-dev#17858)
  DEPR: Deprecate the convert parameter completely (pandas-dev#17831)
  ...
yeemey pushed a commit to yeemey/pandas that referenced this pull request Oct 20, 2017
@reidy-p @yeemey
DOC: Adding examples to update docstring (pandas-dev#16812) (pandas-d…
f5c1932 
…ev#17859)

* DOC: Adding examples to update docstring (pandas-dev#16812)

* formatting issues

* improving examples
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
@reidy-p @alanbato
DOC: Adding examples to update docstring (pandas-dev#16812) (pandas-d…
86c341d 
…ev#17859)

* DOC: Adding examples to update docstring (pandas-dev#16812)

* formatting issues

* improving examples
@reidy-p reidy-p deleted the update_examples branch November 17, 2017 22:37
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@reidy-p @No-Stream
DOC: Adding examples to update docstring (pandas-dev#16812) (pandas-d…
6189b10 
…ev#17859)

* DOC: Adding examples to update docstring (pandas-dev#16812)

* formatting issues

* improving examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

DOC: DataFrame.update() fails to change values in calling dataframe if new value is NaN
4 participants
@reidy-p @pep8speaks @jreback @jorisvandenbossche