BUG: adds validation for boolean keywords in DataFrame.set_index

[richardjgowers]

ENH: Adds util._validators.validate_keywords_as_bool decorator

• closes inplace kwarg must be of bool type, but other boolean kwargs don't have this restriction #16714
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

I've used a decorator so that we can check all the boolean kwargs at once rather than have a lot of lines of validate_bool_kwarg at the top of every method.

[richardjgowers]

Oh, and if people are happy with this decorator approach, I can go through and give all methods the same treatment/tests

[gfyoung]

Oh, and if people are happy with this decorator approach

Just for reference, can you list 1 - 2 places where this also could be applied? Seems reasonable otherwise, though I would check performance just in the case the decorator imposes too much overhead.

[richardjgowers]

@gfyoung this could/(should according to @jreback #16714 (comment)) be applied to all boolean keyword arguments. So I could go through all of DataFrame, Series etc and decorate all methods with boolean kwargs

[gfyoung]

@richardjgowers : Sure, though if you could specify a couple just for reference which take multiple boolean arguments, that would be great.

[richardjgowers]

@gfyoung just scanning through frame.py I found:

https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L1528
https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L1653
https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L1681
https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L3161
https://github.com/pandas-dev/pandas/blob/master/pandas/core/frame.py#L3638

[jreback]

can you rebase; move note to 0.22.0

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@7495e9a). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master   #17853   +/-   ##
=========================================
  Coverage          ?   91.21%           
=========================================
  Files             ?      163           
  Lines             ?    50048           
  Branches          ?        0           
=========================================
  Hits              ?    45650           
  Misses            ?     4398           
  Partials          ?        0

Flag	Coverage Δ
#multiple	89.02% <100%> (?)
#single	40.27% <100%> (?)

Impacted Files	Coverage Δ
pandas/util/_validators.py	94.82% <100%> (ø)
pandas/core/frame.py	97.75% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7495e9a...9d22f46. Read the comment docs.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@7495e9a). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master   #17853   +/-   ##
=========================================
  Coverage          ?   91.21%           
=========================================
  Files             ?      163           
  Lines             ?    50048           
  Branches          ?        0           
=========================================
  Hits              ?    45650           
  Misses            ?     4398           
  Partials          ?        0

Flag	Coverage Δ
#multiple	89.02% <100%> (?)
#single	40.27% <100%> (?)

Impacted Files	Coverage Δ
pandas/core/frame.py	97.75% <100%> (ø)
pandas/util/_validators.py	94.82% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7495e9a...8c530dd. Read the comment docs.

[jreback]

closing as stale, if you want to work on this, pls ping.