Move timedelta-specific functions to tslibs.timedeltas #17827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17827 +/- ##
==========================================
+ Coverage 91.23% 91.24% +<.01%
==========================================
Files 163 163
Lines 50113 50113
==========================================
+ Hits 45723 45726 +3
+ Misses 4390 4387 -3
Continue to review full report at Codecov.
|
|
This is cut/paste, can be cut down if the diff is too large for easy review. |
|
looks ok, needs a rebase |
|
thanks! |
peterpanmj
pushed a commit
to peterpanmj/pandas
that referenced
this pull request
Oct 31, 2017
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once #17793 is merged then the remaining timedeltas functions can be moved: convert_to_timedelta64 and array_to_timedelta64.
Most of Timedelta and _Timedelta can also be moved over in a follow up.