Skip to content

TST: Add the default separator test for PythonParser #17822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2017
Merged

TST: Add the default separator test for PythonParser #17822

merged 3 commits into from
Oct 11, 2017

Conversation

Licht-T
Copy link
Contributor

@Licht-T Licht-T commented Oct 9, 2017

@codecov
Copy link

codecov bot commented Oct 9, 2017

Codecov Report

Merging #17822 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17822      +/-   ##
==========================================
- Coverage   91.26%   91.24%   -0.02%     
==========================================
  Files         163      163              
  Lines       49980    49980              
==========================================
- Hits        45613    45604       -9     
- Misses       4367     4376       +9
Flag Coverage Δ
#multiple 89.04% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.74% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0ee53...a787c20. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 9, 2017 •
edited
Loading

Codecov Report

Merging #17822 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17822      +/-   ##
==========================================
+ Coverage   91.22%   91.23%   +<.01%     
==========================================
  Files         163      163              
  Lines       50014    50014              
==========================================
+ Hits        45627    45630       +3     
+ Misses       4387     4384       -3
Flag Coverage Δ
#multiple 89.04% <ø> (+0.02%) ⬆️
#single 40.24% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 727ea20...c273d9b. Read the comment docs.

@gfyoung gfyoung added IO CSV read_csv, to_csv Testing pandas testing functions or related to the test suite labels Oct 9, 2017
@jreback jreback added this to the 0.21.0 milestone Oct 10, 2017
@jreback
Copy link
Contributor

jreback commented Oct 10, 2017

so this is just validating what we already do? no actual change / bug?

@gfyoung @Licht-T

@gfyoung
Copy link
Member

gfyoung commented Oct 10, 2017

so this is just validating what we already do? no actual change / bug?

Yep, just validation

@jreback
Copy link
Contributor

jreback commented Oct 10, 2017

also does this warrant a small note on the doc-string as well?

@gfyoung
Copy link
Member

gfyoung commented Oct 10, 2017

also does this warrant a small note on the doc-string as well?

Maybe: we could mention that we use Python's builtin sniffer tool from the csv library.

@Licht-T
Copy link
Contributor Author

Licht-T commented Oct 11, 2017

@gfyoung Added the comment.

@Licht-T
Copy link
Contributor Author

Licht-T commented Oct 11, 2017

@jreback @gfyoung Should I also add the document?

@gfyoung
Copy link
Member

gfyoung commented Oct 11, 2017

Should I also add the document?

I think so. Look at the documentation for sep and add that we use Python's builtin sniffer for the Python engine (need to add both in parsers.py and io.rst).

gfyoung
gfyoung reviewed Oct 11, 2017
View reviewed changes
pandas/tests/io/parser/python_parser_only.py Outdated
@@ -21,6 +21,7 @@ class PythonParserTests(object):

def test_default_separator(self):
# GH17333
# The csv parser in Python treats 'o' as separator.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not "parser", actually "sniffer"

@Licht-T Licht-T force-pushed the add-python-parser-default-sep-test branch from 7c06e01 to c273d9b Compare October 11, 2017 13:41
@Licht-T
Copy link
Contributor Author

Licht-T commented Oct 11, 2017

@gfyoung Fixed & Added the document.

@TomAugspurger
Copy link
Contributor

Same issue with the matplotlib failures that'll be fixed by testing the merge commit.

Thanks again @Licht-T

@TomAugspurger TomAugspurger merged commit 7e159ae into pandas-dev:master Oct 11, 2017
ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
@Licht-T
TST: Add the default separator test for PythonParser (pandas-dev#17822)
d036735 
* TST: Add the default separator test for PythonParser

* DOC: Add comment of Python CSV default separator test

* DOC: Add the document about how PythonParser sniffing the separator
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
@Licht-T @alanbato
TST: Add the default separator test for PythonParser (pandas-dev#17822)
411fed3 
* TST: Add the default separator test for PythonParser

* DOC: Add comment of Python CSV default separator test

* DOC: Add the document about how PythonParser sniffing the separator
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@Licht-T @No-Stream
TST: Add the default separator test for PythonParser (pandas-dev#17822)
4c16faa 
* TST: Add the default separator test for PythonParser

* DOC: Add comment of Python CSV default separator test

* DOC: Add the document about how PythonParser sniffing the separator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
IO CSV read_csv, to_csv Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

Problem detecting separator (sep=None) with a DataFrame with a single column
4 participants
@Licht-T @jreback @gfyoung @TomAugspurger