[WIP] TST/MAINT: split up test_resample.py (GH17806) #17808
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Clean
Testing
jreback
requested changes
Oct 8, 2017
| return factory(*args, **kwargs) | ||
|
|
||
| @pytest.fixture | ||
| def _index_start(self): |
There was a problem hiding this comment.
we can prob de-privatize these (_index_start -> index_start)
| bday = BDay() | ||
|
|
||
| # The various methods we support | ||
| downsample_methods = ['min', 'max', 'first', 'last', 'sum', 'mean', 'sem', |
There was a problem hiding this comment.
is there a reason you just didn't put these in base.py?
|
|
||
| assert_frame_equal(frame.resample('60s').mean(), frame_3s) | ||
|
|
||
| def test_resample_timedelta_values(self): |
| freq='D', tz='Europe/Paris')), | ||
| 'D Frequency') | ||
|
|
||
| def test_resample_with_nat(self): |
There was a problem hiding this comment.
ideally push this down to base os can do for all types of resampling (can be future PR)
jreback
reviewed
Oct 8, 2017
| @@ -0,0 +1,220 @@ | |||
| # pylint: disable=E1101 | |||
|
|
|||
There was a problem hiding this comment.
you need to add this sub-dir in setup.py (pandas.tests.resample)
|
@winklerand love for you to continue on this. pls rebase when you can. |
|
can you rebase this |
|
closing as stale. if you want to continue working, pls ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff