Skip to content

DOC: Clarifying use of categorical data in describe docstring (#16722) #17789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2017

Conversation

reidy-p
Copy link
Contributor

@reidy-p reidy-p commented Oct 4, 2017

@pep8speaks
Copy link

pep8speaks commented Oct 4, 2017

Hello @reidy-p! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on October 04, 2017 at 20:50 Hours UTC

@gfyoung gfyoung added the Docs label Oct 4, 2017
@codecov
Copy link

codecov bot commented Oct 5, 2017

Codecov Report

Merging #17789 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17789      +/-   ##
==========================================
- Coverage   91.24%   91.22%   -0.02%     
==========================================
  Files         163      163              
  Lines       49916    49916              
==========================================
- Hits        45544    45535       -9     
- Misses       4372     4381       +9
Flag Coverage Δ
#multiple 89.02% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 92.1% <ø> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.73% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48d0460...b300fb5. Read the comment docs.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jorisvandenbossche jorisvandenbossche added this to the 0.21.0 milestone Oct 5, 2017
@jreback jreback merged commit d099f88 into pandas-dev:master Oct 5, 2017
@jreback
Copy link
Contributor

jreback commented Oct 5, 2017

thanks!

@reidy-p reidy-p deleted the describe_docs branch October 5, 2017 22:08
ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame.describe(include=['O']) should include categorical columns
5 participants