BUG: Validate the justify parameter in to_html #17766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @gfyoung! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on October 03, 2017 at 18:20 Hours UTC |
jschendel
reviewed
Oct 3, 2017
doc/source/whatsnew/v0.21.0.txt
Outdated
| @@ -778,6 +778,7 @@ I/O | |||
| - Bug in :func:`read_html` where import check fails when run in multiple threads (:issue:`16928`) | |||
| - Bug in :func:`read_csv` where automatic delimiter detection caused a ``TypeError`` to be thrown when a bad line was encountered rather than the correct error message (:issue:`13374`) | |||
| - Bug in ``DataFrame.to_html()`` with ``notebook=True`` where DataFrames with named indices or non-MultiIndex indices had undesired horizontal or vertical alignment for column or row labels, respectively (:issue:`16792`) | |||
| - Bug in ``DataFrame.to_html()`` in which there was no validation of the ``justify`` parameter (:issue:`17527`) | |||
There was a problem hiding this comment.
Would it be preferable to use :meth:`DataFrame.to_html` to provide a link? Possibly on the line above too?
There was a problem hiding this comment.
Absolutely! Thanks for pointing that out.
|
lgtm. merge on green. |
Codecov Report
@@ Coverage Diff @@
## master #17766 +/- ##
==========================================
+ Coverage 91.23% 91.24% +<.01%
==========================================
Files 163 163
Lines 49869 49872 +3
==========================================
+ Hits 45499 45504 +5
+ Misses 4370 4368 -2
Continue to review full report at Codecov.
|
|
@jreback , @TomAugspurger : All green, so merging. |
ghost
pushed a commit
to reef-technologies/pandas
that referenced
this pull request
Oct 16, 2017
BUG: Validate the justify parameter in to_html Closes pandas-devgh-17527.
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
BUG: Validate the justify parameter in to_html Closes pandas-devgh-17527.
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
BUG: Validate the justify parameter in to_html Closes pandas-devgh-17527.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17527
cc @TomAugspurger