Skip to content

Adding lxml to requirements_dev.txt #17748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2017
Merged

Adding lxml to requirements_dev.txt #17748

merged 1 commit into from
Nov 1, 2017

Conversation

datapythonista
Copy link
Member

@jreback
Copy link
Contributor

jreback commented Oct 3, 2017

can you add the skip where needed?

@jreback jreback added the Dependencies Required and optional dependencies label Oct 3, 2017
@datapythonista
Copy link
Member Author

Added @jreback, thanks for taking care of this.

@jreback jreback added this to the 0.22.0 milestone Oct 31, 2017
@jreback jreback added the Testing pandas testing functions or related to the test suite label Oct 31, 2017
@jreback
Copy link
Contributor

jreback commented Oct 31, 2017

@TomAugspurger does this fix the original issue?

@datapythonista can you rebase

@datapythonista
Copy link
Member Author

@jreback, not sure if I'm missing anything, but I see the PR already rebased, isn't it?

@jreback jreback merged commit 881ee30 into pandas-dev:master Nov 1, 2017
@jreback
Copy link
Contributor

jreback commented Nov 1, 2017

thanks @datapythonista

1kastner pushed a commit to 1kastner/pandas that referenced this pull request Nov 5, 2017
@datapythonista @1kastner
Adding skip to test failing because of lxml import (pandas-dev#17747) (…
88bf001 
…pandas-dev#17748)
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@datapythonista @No-Stream
Adding skip to test failing because of lxml import (pandas-dev#17747) (…
c5a70dd 
…pandas-dev#17748)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Dependencies Required and optional dependencies Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

lxml missing from requirements_dev.txt
2 participants
@datapythonista @jreback