Skip to content

allow neg index on str_get #17741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2017
Merged

allow neg index on str_get #17741

merged 1 commit into from
Oct 2, 2017

Conversation

bobhaffner
Copy link
Contributor

@jreback jreback added this to the 0.21.0 milestone Oct 2, 2017
@jreback jreback added Bug Strings String extension data type and string data labels Oct 2, 2017
@jreback
Copy link
Contributor

jreback commented Oct 2, 2017

lgtm. ping on green.

@codecov
Copy link

codecov bot commented Oct 2, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a3d538a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #17741   +/-   ##
=========================================
  Coverage          ?   91.21%           
=========================================
  Files             ?      163           
  Lines             ?    49856           
  Branches          ?        0           
=========================================
  Hits              ?    45475           
  Misses            ?     4381           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.01% <100%> (?)
#single 40.25% <0%> (?)
Impacted Files Coverage Δ
pandas/core/strings.py 98.46% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d538a...1f325cc. Read the comment docs.

@jreback jreback merged commit 97fea48 into pandas-dev:master Oct 2, 2017
@jreback
Copy link
Contributor

jreback commented Oct 2, 2017

thanks!

@bobhaffner
Copy link
Contributor Author

Thanks @jreback

@bobhaffner bobhaffner deleted the str_get_allow_neg_index branch October 2, 2017 20:00
ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
@bobhaffner
allow neg index on str_get (pandas-dev#17741)
93e2405
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
@bobhaffner @alanbato
allow neg index on str_get (pandas-dev#17741)
b48cb0f
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@bobhaffner @No-Stream
allow neg index on str_get (pandas-dev#17741)
c2f2e9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Strings String extension data type and string data
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

String methods get() does not insert NaNs on negative index out of range
2 participants
@bobhaffner @jreback