BUG: GH17525 Function _get_standard_colors resets global random seed #17730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17730 +/- ##
==========================================
- Coverage 91.27% 91.23% -0.04%
==========================================
Files 163 163
Lines 49766 49859 +93
==========================================
+ Hits 45422 45490 +68
- Misses 4344 4369 +25
Continue to review full report at Codecov.
|
gfyoung
reviewed
Oct 1, 2017
pandas/plotting/_style.py
Outdated
| @@ -114,8 +114,11 @@ def _get_standard_colors(num_colors=None, colormap=None, color_type='default', | |||
| import random | |||
|
|
|||
| def random_color(column): | |||
| rstate = random.getstate() # to avoid resetting the seed | |||
There was a problem hiding this comment.
Also, since you're changing the behavior, let's document it. A brief doc-string would be good here for future developers.
|
@cmazzullo : Also, you're definitely going to need tests. |
|
Hello @cmazzullo! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on October 03, 2017 at 08:06 Hours UTC |
|
Okay, just added one. |
jreback
requested changes
Oct 1, 2017
pandas/plotting/_style.py
Outdated
| @@ -114,8 +114,13 @@ def _get_standard_colors(num_colors=None, colormap=None, color_type='default', | |||
| import random | |||
|
|
|||
| def random_color(column): | |||
There was a problem hiding this comment.
I don't think random provides a context manger, maybe do this like:
rstate = random.getstate()
try:
random.seed(...)
return = [random...... ]
finally:
random.setstate(rstate)
There was a problem hiding this comment.
actually just use this
In [20]: rs = pandas.core.common._random_state()
In [21]: rs.rand(3)
Out[21]: array([ 0.6786481 , 0.94231001, 0.03334007])
jreback
reviewed
Oct 1, 2017
doc/source/whatsnew/v0.21.0.txt
Outdated
| @@ -614,6 +614,7 @@ Plotting | |||
| - Line plots no longer assume monotonic x data when calculating xlims, they show the entire lines now even for unsorted x data. (:issue:`11310`, :issue:`11471`) | |||
| - With matplotlib 2.0.0 and above, calculation of x limits for line plots is left to matplotlib, so that its new default settings are applied. (:issue:`15495`) | |||
| - Bug in ``Series.plot.bar`` or ``DataFramee.plot.bar`` with ``y`` not respecting user-passed ``color`` (:issue:`16822`) | |||
| - Bug in ``plotting._style._get_standard_colors`` resetting the random seed when generating random colors (:issue:`17525`) | |||
There was a problem hiding this comment.
reference the user visibile issue (e.g. parallel coordinates)?
gfyoung
reviewed
Oct 1, 2017
pandas/tests/plotting/test_misc.py
Outdated
| @@ -284,3 +284,20 @@ def test_subplot_titles(self): | |||
| title=title[:-1]) | |||
| title_list = [ax.get_title() for sublist in plot for ax in sublist] | |||
| assert title_list == title[:3] + [''] | |||
|
|
|||
| def test_get_standard_colors_random_seed(self): | |||
| """ For #17525 """ | |||
There was a problem hiding this comment.
Generally, we just add a comment above, not a docstring.
jreback
approved these changes
Oct 1, 2017
doc/source/whatsnew/v0.21.0.txt
Outdated
| @@ -614,6 +614,7 @@ Plotting | |||
| - Line plots no longer assume monotonic x data when calculating xlims, they show the entire lines now even for unsorted x data. (:issue:`11310`, :issue:`11471`) | |||
| - With matplotlib 2.0.0 and above, calculation of x limits for line plots is left to matplotlib, so that its new default settings are applied. (:issue:`15495`) | |||
| - Bug in ``Series.plot.bar`` or ``DataFramee.plot.bar`` with ``y`` not respecting user-passed ``color`` (:issue:`16822`) | |||
| - Bug in ``plotting._style._get_standard_colors`` causing ``plotting.parallel_coordinates`` to reset the random seed when using random colors (:issue:`17525`) | |||
There was a problem hiding this comment.
you don't need the first part, a user won't know what you are talking about.
jreback
reviewed
Oct 2, 2017
pandas/plotting/_style.py
Outdated
| """ Returns a random color represented as a list of length 3""" | ||
| # GH17525 use common._random_state to avoid resetting the seed | ||
| rs = _random_state() | ||
| return rs.rand(3) |
There was a problem hiding this comment.
return rs.rand(3).tolist() will make this work.
|
@cmazzullo Thanks! |
|
Sure thing |
ghost
pushed a commit
to reef-technologies/pandas
that referenced
this pull request
Oct 16, 2017
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff