Skip to content

CI: Pin miniconda version #17700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 28, 2017
Merged

Conversation

TomAugspurger
Copy link
Contributor

xref #17696

@codecov
Copy link

codecov bot commented Sep 27, 2017

Codecov Report

Merging #17700 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17700      +/-   ##
==========================================
- Coverage   91.27%   91.25%   -0.02%     
==========================================
  Files         163      163              
  Lines       49760    49760              
==========================================
- Hits        45416    45407       -9     
- Misses       4344     4353       +9
Flag Coverage Δ
#multiple 89.04% <ø> (ø) ⬆️
#single 40.34% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.73% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d88cd...09d8a74. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 27, 2017

Codecov Report

Merging #17700 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17700      +/-   ##
==========================================
- Coverage   91.27%   91.25%   -0.02%     
==========================================
  Files         163      163              
  Lines       49760    49760              
==========================================
- Hits        45416    45407       -9     
- Misses       4344     4353       +9
Flag Coverage Δ
#multiple 89.04% <ø> (ø) ⬆️
#single 40.34% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.73% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d88cd...7bc883e. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Sep 28, 2017

btw the last time I had to do this I put the things that I would later revert in a specific commit so it was easy. (so create an issue to revert this when conda is fixed)

@jreback jreback added the CI Continuous Integration label Sep 28, 2017
@TomAugspurger
Copy link
Contributor Author

OK, hopefully that commit does it.

When I revert this, I'll add another commit that keeps

  • fix the beautifulsoup4 package name
  • fix the bzip2 skip if it's not available

@jreback jreback added this to the 0.21.0 milestone Sep 28, 2017
@jreback jreback merged commit eaa5081 into pandas-dev:master Sep 28, 2017
@jreback
Copy link
Contributor

jreback commented Sep 28, 2017

thanks @TomAugspurger can fixup if needed later. let's open an issue to track this & revert when we can.

@TomAugspurger TomAugspurger deleted the pin-minconda branch September 28, 2017 10:53
TomAugspurger added a commit that referenced this pull request Sep 28, 2017
TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request Oct 2, 2017
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants