Skip to content

DOC: Correct wrong doc string for MultiIndex.get_loc_level + added examples #17663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2017
Merged

DOC: Correct wrong doc string for MultiIndex.get_loc_level + added examples #17663

merged 1 commit into from
Sep 25, 2017

Conversation

topper-123
Copy link
Contributor

  • [x ] passes git diff upstream/master -u -- "*.py" | flake8 --diff

The doc string for MultiIndex.get_loc_level is currently wrong. This corrects that + adds some examples.

jreback
jreback reviewed Sep 25, 2017
View reviewed changes
pandas/core/indexes/multi.py Outdated
key : label or sequence of labels
level : int/level name or list thereof, optional
drop_level : bool, default True
if ``False``, the output index will not be sliced.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this a bit more clear

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, new version

@jreback jreback added this to the 0.21.0 milestone Sep 25, 2017
@jreback
Copy link
Contributor

jreback commented Sep 25, 2017

tiny comment

@topper-123 topper-123 force-pushed the multiindex.get_loc_level branch from 8f6b9e5 to 3d8933c Compare September 25, 2017 11:25
@codecov
Copy link

codecov bot commented Sep 25, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@9d0db60). Click here to learn what that means.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #17663   +/-   ##
=========================================
  Coverage          ?   91.24%           
=========================================
  Files             ?      163           
  Lines             ?    49806           
  Branches          ?        0           
=========================================
  Hits              ?    45446           
  Misses            ?     4360           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.04% <92.85%> (?)
#single 40.3% <7.14%> (?)
Impacted Files Coverage Δ
pandas/core/indexes/multi.py 96.9% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0db60...3d8933c. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 25, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@9d0db60). Click here to learn what that means.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #17663   +/-   ##
=========================================
  Coverage          ?   91.24%           
=========================================
  Files             ?      163           
  Lines             ?    49806           
  Branches          ?        0           
=========================================
  Hits              ?    45446           
  Misses            ?     4360           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.04% <92.85%> (?)
#single 40.3% <7.14%> (?)
Impacted Files Coverage Δ
pandas/core/indexes/multi.py 96.9% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0db60...3d8933c. Read the comment docs.

@jreback jreback merged commit 83c9205 into pandas-dev:master Sep 25, 2017
@jreback
Copy link
Contributor

jreback commented Sep 25, 2017

thanks!

@topper-123 topper-123 deleted the multiindex.get_loc_level branch September 26, 2017 09:39
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
@topper-123 @alanbato
Correct wrong doc string for MultiIndex.get_loc_level + added examples (
f351307 
pandas-dev#17663)
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@topper-123 @No-Stream
Correct wrong doc string for MultiIndex.get_loc_level + added examples (
0707b08 
pandas-dev#17663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Docs MultiIndex
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@topper-123 @jreback