Skip to content

Removed duplicated _constructor_sliced definition in sparse.frame #17604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Removed duplicated _constructor_sliced definition in sparse.frame #17604

merged 1 commit into from
Sep 20, 2017

Conversation

avmarchenko
Copy link
Contributor

Removal of duplicated code in core.sparse.frame

@codecov
Copy link

codecov bot commented Sep 20, 2017

Codecov Report

Merging #17604 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17604      +/-   ##
==========================================
- Coverage   91.19%   91.17%   -0.02%     
==========================================
  Files         163      163              
  Lines       49626    49625       -1     
==========================================
- Hits        45258    45248      -10     
- Misses       4368     4377       +9
Flag Coverage Δ
#multiple 88.96% <ø> (-0.01%) ⬇️
#single 40.19% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/sparse/frame.py 94.69% <ø> (-0.02%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c3642...1c75100. Read the comment docs.

@avmarchenko
Copy link
Contributor Author

avmarchenko commented Sep 20, 2017

The one failed travis-ci build seems due to "CondaHTTPError".

@TomAugspurger
Copy link
Contributor

Restarted those workers.

Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@gfyoung gfyoung merged commit 40c499f into pandas-dev:master Sep 20, 2017
@gfyoung
Copy link
Member

gfyoung commented Sep 20, 2017

Thanks @avmarchenko !

@gfyoung gfyoung added the Clean label Sep 20, 2017
@gfyoung gfyoung added this to the 0.21.0 milestone Sep 20, 2017
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants