Remove experimental warning from custom offsets #17584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAIK, you do not need to add a |
gfyoung
approved these changes
Sep 19, 2017
TomAugspurger
approved these changes
Sep 19, 2017
jschendel
force-pushed
the
custom-offset-remove-experimental
branch
from
dd6a302 to
ba1c154
Compare
Codecov Report
@@ Coverage Diff @@
## master #17584 +/- ##
==========================================
- Coverage 91.22% 91.2% -0.02%
==========================================
Files 163 163
Lines 49625 49625
==========================================
- Hits 45270 45261 -9
- Misses 4355 4364 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17584 +/- ##
==========================================
- Coverage 91.22% 91.2% -0.02%
==========================================
Files 163 163
Lines 49625 49625
==========================================
- Hits 45270 45261 -9
- Misses 4355 4364 +9
Continue to review full report at Codecov.
|
jreback
approved these changes
Sep 21, 2017
|
Thanks! |
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion here: #17554 (review)
git diff upstream/master -u -- "*.py" | flake8 --diffI edited the docstring descriptions slightly. Feel free to suggest cleaner descriptions, if my edits don't suffice. Should there be a whatsnew entry related to removing the experimental status?