Spelling and grammar #17548
Spelling and grammar #17548
Conversation
|
Hello @Giftlin! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on September 15, 2017 at 21:09 Hours UTC |
|
|
||
| The underlying mappings are stored in a list. That list is public and can | ||
| accessed or updated using the *maps* attribute. There is no other state. |
There was a problem hiding this comment.
Keep the space after the period.
There was a problem hiding this comment.
I see that it's because of flake8 issue. Perhaps replace the "or" with a slash to get it to fit. 😄
There was a problem hiding this comment.
Are 2 whitespaces necessary? It had two, reduced to one.
There was a problem hiding this comment.
Can the slash have spaces before and after?
Codecov Report
@@ Coverage Diff @@
## master #17548 +/- ##
==========================================
- Coverage 91.25% 91.23% -0.02%
==========================================
Files 163 163
Lines 49606 49606
==========================================
- Hits 45266 45257 -9
- Misses 4340 4349 +9
Continue to review full report at Codecov.
|
pandas/compat/chainmap_impl.py
Outdated
| @@ -35,9 +35,9 @@ def wrapper(self): | |||
| class ChainMap(MutableMapping): | |||
| """ A ChainMap groups multiple dicts (or other mappings) together | |||
| to create a single, updatable view. | |||
|
|
|||
There was a problem hiding this comment.
Did you add a whitespace by accident?
Codecov Report
@@ Coverage Diff @@
## master #17548 +/- ##
==========================================
- Coverage 91.25% 91.23% -0.02%
==========================================
Files 163 163
Lines 49606 49606
==========================================
- Hits 45266 45257 -9
- Misses 4340 4349 +9
Continue to review full report at Codecov.
|
|
Don't worry about it. Yellow means the tests are still running. You should only get concerned if it turns red. |
|
@gfyoung all checks have passed. |
|
Thanks @Giftlin ! |
git diff upstream/master -u -- "*.py" | flake8 --diff