Skip to content

TST: sql flaky test: check less decimals (#17510) #17538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2017
Merged

TST: sql flaky test: check less decimals (#17510) #17538

merged 1 commit into from
Sep 17, 2017

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche mentioned this pull request Sep 15, 2017
Closed
@jreback jreback added IO SQL to_sql, read_sql, read_sql_query Testing pandas testing functions or related to the test suite labels Sep 15, 2017
@jreback jreback added this to the 0.21.0 milestone Sep 15, 2017
TomAugspurger
TomAugspurger approved these changes Sep 15, 2017
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the failure was under the "Allowed Failures", so you'll need to click through to Travis to check if it passed.

@codecov
Copy link

codecov bot commented Sep 15, 2017 •
edited
Loading

Codecov Report

Merging #17538 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17538      +/-   ##
==========================================
- Coverage   91.25%   91.23%   -0.02%     
==========================================
  Files         163      163              
  Lines       49606    49606              
==========================================
- Hits        45266    45257       -9     
- Misses       4340     4349       +9
Flag Coverage Δ
#multiple 89.01% <ø> (ø) ⬆️
#single 40.19% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c3888...b70a19f. Read the comment docs.

@jreback jreback merged commit 371caaa into pandas-dev:master Sep 17, 2017
@jreback
Copy link
Contributor

jreback commented Sep 17, 2017

thanks!

alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
@jorisvandenbossche @alanbato
TST: sql flaky test: check less decimals (pandas-dev#17510) (pandas-d…
1bb069e 
…ev#17538)
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@jorisvandenbossche @No-Stream
TST: sql flaky test: check less decimals (pandas-dev#17510) (pandas-d…
b9cac1b 
…ev#17538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
IO SQL to_sql, read_sql, read_sql_query Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

Test failure pandas.tests.io.test_sql.TestXSQLite
3 participants
@jorisvandenbossche @jreback @TomAugspurger