Skip to content

remove period_helper from non-period reqs #17531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2017

Conversation

jbrockmendel
Copy link
Member

There are a bunch of other reqs that could be removed (e.g. every direct reference to src/util, all of lib_depends), but at least period_helper it's obvious why it belongs where it does.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

  • In the file setup.py, following are the PEP8 issues :

Line 480:80: E501 line too long (84 > 79 characters)

@jreback
Copy link
Contributor

jreback commented Sep 14, 2017

looks fine. ping on green.

@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Sep 14, 2017
@jreback jreback added this to the 0.21.0 milestone Sep 14, 2017
@codecov
Copy link

codecov bot commented Sep 14, 2017

Codecov Report

Merging #17531 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17531      +/-   ##
==========================================
- Coverage   91.24%    91.2%   -0.05%     
==========================================
  Files         163      163              
  Lines       49582    49586       +4     
==========================================
- Hits        45242    45225      -17     
- Misses       4340     4361      +21
Flag Coverage Δ
#multiple 88.99% <ø> (-0.03%) ⬇️
#single 40.2% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.23% <0%> (-1.82%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️
pandas/core/dtypes/concat.py 98.26% <0%> (-0.03%) ⬇️
pandas/core/categorical.py 95.57% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97abd2c...92251f4. Read the comment docs.

@jbrockmendel
Copy link
Member Author

ping.

@jreback jreback merged commit 06a6e63 into pandas-dev:master Sep 14, 2017
@jreback
Copy link
Contributor

jreback commented Sep 14, 2017

thanks!

@jbrockmendel jbrockmendel deleted the setup_reqs branch October 30, 2017 16:24
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants