Remove from numpy cimport * #17521
Merged
Remove from numpy cimport * #17521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-b1
suggested changes
Sep 13, 2017
pandas/_libs/algos.pyx
Outdated
| cdef extern from "../src/headers/math.h": | ||
| double sqrt(double x) nogil | ||
| double fabs(double) nogil | ||
| from cpython.math cimport sqrt, fabs |
There was a problem hiding this comment.
I think you want libc.math here?
There was a problem hiding this comment.
Good catch. Just pushed a fix.
pandas/_libs/groupby.pyx
Outdated
| @@ -1,16 +1,17 @@ | |||
| # cython: profile=False | |||
|
|
|||
| from numpy cimport * | |||
| cimport numpy as np | |||
There was a problem hiding this comment.
we're inconsistent about this, but at least I prefer the cimport numpy as cnp, so it is clearer which parts need c-level access (edit: cnp)
pandas/_libs/reshape.pyx
Outdated
|
|
||
| from numpy cimport (int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, | ||
| from numpy cimport (ndarray, | ||
| int8_t, int16_t, int32_t, int64_t, uint8_t, uint16_t, |
jreback
added
the
Compat
Codecov Report
@@ Coverage Diff @@
## master #17521 +/- ##
==========================================
+ Coverage 91.18% 91.23% +0.04%
==========================================
Files 163 163
Lines 49543 49606 +63
==========================================
+ Hits 45177 45256 +79
+ Misses 4366 4350 -16
Continue to review full report at Codecov.
|
|
looks ok to me. @chris-b1 |
chris-b1
approved these changes
Sep 17, 2017
|
thanks @jbrockmendel |
jorisvandenbossche
added a commit
that referenced
this pull request
Sep 17, 2017
This reverts commit 138be88.
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace these imports with explicit imports.
There are a couple of other similar things coming up, splitting them apart for easier review.
There are a couple of places with
cdef extern from "../src/headers/math.h":but I don't think the path here makes sense. The fact that it works anyway bothers me. This PR changes one such occurrence as a demonstration, leaves the others for the next PR.git diff upstream/master -u -- "*.py" | flake8 --diff