COMPAT: followup to #17491 #17503
Merged
COMPAT: followup to #17491 #17503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
the
Compat
Codecov Report
@@ Coverage Diff @@
## master #17503 +/- ##
==========================================
- Coverage 91.18% 91.16% -0.02%
==========================================
Files 163 163
Lines 49543 49545 +2
==========================================
- Hits 45177 45170 -7
- Misses 4366 4375 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17503 +/- ##
==========================================
- Coverage 91.18% 91.16% -0.02%
==========================================
Files 163 163
Lines 49543 49545 +2
==========================================
- Hits 45177 45169 -8
- Misses 4366 4376 +10
Continue to review full report at Codecov.
|
gfyoung
reviewed
Sep 13, 2017
doc/source/whatsnew/v0.21.0.txt
Outdated
| @@ -193,16 +193,16 @@ the target. Now, a ``ValueError`` will be raised when such an input is passed in | |||
| Iteration of Series/Index will now return python scalars | |||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| Previously, when using certain iteration methods for a ``Series`` with dtype ``int`` or ``float``, you would receive a ``numpy`` scalar, e.g. a ``np.int64``, rather than a python ``int``. Issue (:issue:`10904`) corrected this for ``Series.tolist()`` and ``list(Series)``. This change makes all iteration methods consistent, in particular, for ``__iter__()`` and ``.map()``; note that this only affect int/float dtypes. (:issue:`13236`, :issue:`13258`, :issue:`14216`). | |||
| Previously, when using certain iteration methods for a ``Series`` with dtype ``int`` or ``float``, you would receive a ``numpy`` scalar, e.g. a ``np.int64``, rather than a python ``int``. Issue (:issue:`10904`) corrected this for ``Series.tolist()`` and ``list(Series)``. This change makes all iteration methods consistent, in particular, for ``__iter__()`` and ``.map()``; note that this only affects int/float dtypes. (:issue:`13236`, :issue:`13258`, :issue:`14216`). | |||
There was a problem hiding this comment.
python --> Python (same thing in the doc-strings that you changed)
gfyoung
reviewed
Sep 13, 2017
pandas/core/base.py
Outdated
| @@ -892,18 +892,27 @@ def argmin(self, axis=None): | |||
|
|
|||
| def tolist(self): | |||
| """ | |||
| return a list of the values; box to scalars | |||
| return a list of the values. These are each a scalar type, which is | |||
There was a problem hiding this comment.
Capitalize that first sentence (same with __iter__ doc-string)
gfyoung
reviewed
Sep 13, 2017
| @@ -1102,3 +1136,40 @@ def test_categorial_datetimelike(self, method): | |||
|
|
|||
| result = method(i)[0] | |||
| assert isinstance(result, Timestamp) | |||
|
|
|||
| def test_iter_box(self): | |||
There was a problem hiding this comment.
Is this just a new test for coverage purposes or related to any of the issues you addressed?
gfyoung
approved these changes
Sep 13, 2017
| """ iterate like Categorical """ | ||
| return self._data.__iter__() | ||
| def tolist(self): | ||
| return self._data.tolist() |
There was a problem hiding this comment.
I don't think this is needed? Base Index already defines this as self._values.tolist(), and _values and _data is both a Categorical ?
jreback
pushed a commit
that referenced
this pull request
Sep 17, 2017
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.