added nearest to resample + test #17498

ab320012 · 2017-09-11T19:37:58Z

closes Resample nearest #17496
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

gfyoung · 2017-09-11T19:53:06Z

pandas/core/resample.py

+        DataFrame.fillna
+        """
+        return self._upsample('nearest', limit=limit)
+    nearest = nearest


Remove this line.

codecov · 2017-09-11T20:10:47Z

Codecov Report

Merging #17498 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #17498      +/-   ##
==========================================
- Coverage   91.15%   91.13%   -0.02%     
==========================================
  Files         163      163              
  Lines       49534    49537       +3     
==========================================
- Hits        45153    45147       -6     
- Misses       4381     4390       +9

Flag	Coverage Δ
#multiple	`88.92% <100%> (ø)`	⬆️
#single	`40.22% <66.66%> (-0.06%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/resample.py	`96.17% <100%> (+0.01%)`	⬆️
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/frame.py	`97.72% <0%> (-0.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46856c3...1195b49. Read the comment docs.

codecov · 2017-09-11T20:10:56Z

Codecov Report

Merging #17498 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #17498      +/-   ##
==========================================
- Coverage   91.25%   91.21%   -0.05%     
==========================================
  Files         163      163              
  Lines       49614    49616       +2     
==========================================
- Hits        45274    45255      -19     
- Misses       4340     4361      +21

Flag	Coverage Δ
#multiple	`88.99% <100%> (-0.03%)`	⬇️
#single	`40.2% <50%> (-0.06%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/resample.py	`96.17% <100%> (+0.01%)`	⬆️
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/plotting/_converter.py	`63.23% <0%> (-1.82%)`	⬇️
pandas/core/frame.py	`97.77% <0%> (-0.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5cfdbb...82933d1. Read the comment docs.

gfyoung · 2017-09-11T23:20:29Z

pandas/core/resample.py

@@ -480,6 +480,21 @@ def backfill(self, limit=None):
        return self._upsample('backfill', limit=limit)
    bfill = backfill

+    def nearest(self, limit=None):
+        """
+        Backward or forward fill values


This is not particularly descriptive, at least to me. Also, add a newline beneath this one.

i copy and pasted the structure from surrounding code

Well then, take advantage of this opportunity to improve upon it 😄

gfyoung · 2017-09-11T23:20:44Z

pandas/core/resample.py

+        Series.fillna
+        DataFrame.fillna
+        """
+        return self._upsample('nearest', limit=limit)


Since you're returning something, add a "Returns" section too.

gfyoung · 2017-09-11T23:21:50Z

not sure to push whats new entry for such simple change

I think you can just say that we have added support for a new sampling method that...(for you to fill in)

jreback · 2017-09-12T10:40:22Z

pandas/tests/test_resample.py

@@ -2960,7 +2960,7 @@ def test_methods(self):
            expected = g.B.apply(lambda x: getattr(x.resample('2s'), f)())
            assert_series_equal(result, expected)

-        for f in ['backfill', 'ffill', 'asfreq']:
+        for f in ['nearest', 'backfill', 'ffill', 'asfreq']:


let's add a test for this specifically to make sure its doing the right thing. IOW construct a frame with an expected result (rather than the auto generated one here which might or might now actually do nearest resampling, as it doesn't have nans).

pep8speaks · 2017-09-12T14:48:36Z

Hello @ab320012! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on September 16, 2017 at 14:01 Hours UTC

jreback

looks good. couple of comments.

jreback · 2017-09-15T10:19:28Z

doc/source/whatsnew/v0.21.0.txt

@@ -28,6 +28,8 @@ New features
  and :class:`~pandas.ExcelWriter` to work properly with the file system path protocol (:issue:`13823`)
 - Added ``skipna`` parameter to :func:`~pandas.api.types.infer_dtype` to
  support type inference in the presence of missing values (:issue:`17059`).
+- Added ``nearest`` method to :class:`~pandas.Resampler` to support


:class:`~pandas.Resampler.nearest` is added

add in apt.rst as well.

jreback · 2017-09-15T10:19:37Z

pandas/core/resample.py

@@ -463,6 +467,26 @@ def pad(self, limit=None):
        return self._upsample('pad', limit=limit)
    ffill = pad

+    def nearest(self, limit=None):
+        """


versionadded tag

jreback · 2017-09-15T10:19:56Z

pandas/tests/test_resample.py

@@ -2934,6 +2934,21 @@ def test_getitem_multiple(self):
        result = r['buyer'].count()
        assert_series_equal(result, expected)

+    def test_nearest(self):
+        index = pd.date_range('1/1/2000', periods=3, freq='T')


add the issue number as a comment

jreback · 2017-09-15T10:20:18Z

pandas/tests/test_resample.py

+                 '2000-01-01 00:02:00'],
+                dtype='datetime64[ns]',
+                freq='20S'))
+        assert_series_equal(result, expected)


can you add a test with limit as well

…d functions

jreback · 2017-09-17T21:21:15Z

thanks @ab320012 nice add, and very responsive! keep em coming!

…d functions (pandas-dev#17498)

gfyoung reviewed Sep 11, 2017

View reviewed changes

ab320012 force-pushed the master branch from f0630c3 to 1195b49 Compare September 11, 2017 20:10

gfyoung added the Resample resample method label Sep 11, 2017

gfyoung reviewed Sep 11, 2017

View reviewed changes

jreback requested changes Sep 12, 2017

View reviewed changes

ab320012 force-pushed the master branch 12 times, most recently from f6e6933 to da621bc Compare September 14, 2017 19:19

jreback requested changes Sep 15, 2017

View reviewed changes

ab320012 force-pushed the master branch 2 times, most recently from 541892a to ea46a07 Compare September 15, 2017 12:06

added support for nearest upsample + comments on returns for upsample…

82933d1

…d functions

ab320012 force-pushed the master branch from ea46a07 to 82933d1 Compare September 16, 2017 14:01

jreback added the Enhancement label Sep 17, 2017

jreback added this to the 0.21.0 milestone Sep 17, 2017

jreback approved these changes Sep 17, 2017

View reviewed changes

jreback merged commit 26b461b into pandas-dev:master Sep 17, 2017

alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017

added support for nearest upsample + comments on returns for upsample…

7164199

…d functions (pandas-dev#17498)

No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017

added support for nearest upsample + comments on returns for upsample…

e77d86e

…d functions (pandas-dev#17498)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added nearest to resample + test #17498

added nearest to resample + test #17498

ab320012 commented Sep 11, 2017 •

edited

Loading

gfyoung Sep 11, 2017

ab320012 Sep 11, 2017

codecov bot commented Sep 11, 2017

codecov bot commented Sep 11, 2017 •

edited

Loading

gfyoung Sep 11, 2017

ab320012 Sep 11, 2017

gfyoung Sep 12, 2017

gfyoung Sep 11, 2017

gfyoung commented Sep 11, 2017 •

edited

Loading

jreback Sep 12, 2017

pep8speaks commented Sep 12, 2017 •

edited

Loading

jreback left a comment

jreback Sep 15, 2017

jreback Sep 15, 2017

jreback Sep 15, 2017

jreback Sep 15, 2017

jreback Sep 15, 2017

jreback commented Sep 17, 2017

added nearest to resample + test #17498

added nearest to resample + test #17498

Conversation

ab320012 commented Sep 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Sep 11, 2017

Codecov Report

codecov bot commented Sep 11, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gfyoung commented Sep 11, 2017 • edited Loading

Choose a reason for hiding this comment

pep8speaks commented Sep 12, 2017 • edited Loading

Comment last updated on September 16, 2017 at 14:01 Hours UTC

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Sep 17, 2017

ab320012 commented Sep 11, 2017 •

edited

Loading

codecov bot commented Sep 11, 2017 •

edited

Loading

gfyoung commented Sep 11, 2017 •

edited

Loading

pep8speaks commented Sep 12, 2017 •

edited

Loading