Skip to content

Replace * imports with explicit imports; remove unused declared const… #17470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2017

Conversation

jbrockmendel
Copy link
Member

…ants

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@codecov
Copy link

codecov bot commented Sep 8, 2017

Codecov Report

Merging #17470 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17470      +/-   ##
==========================================
- Coverage   91.16%   91.14%   -0.02%     
==========================================
  Files         163      163              
  Lines       49590    49590              
==========================================
- Hits        45209    45200       -9     
- Misses       4381     4390       +9
Flag Coverage Δ
#multiple 88.93% <ø> (ø) ⬆️
#single 40.25% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.72% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee6185e...24acd44. Read the comment docs.

@gfyoung gfyoung added Clean Internals Related to non-user accessible pandas implementation labels Sep 8, 2017
@jreback jreback added this to the 0.21.0 milestone Sep 8, 2017
@jreback jreback merged commit 46832ac into pandas-dev:master Sep 8, 2017
@jreback
Copy link
Contributor

jreback commented Sep 8, 2017

thanks!

@jreback
Copy link
Contributor

jreback commented Sep 8, 2017

FYI we don't do too much linting for cython files. If you want to add to the script would be helpful (its ci/lint.sh)

@jbrockmendel jbrockmendel deleted the window_imports branch September 8, 2017 02:28
@jbrockmendel
Copy link
Member Author

If you want to add to the script would be helpful (its ci/lint.sh)

I've never had much luck with linting cython. Part of why I like the newer @cython.locals and related decorators is the hope that it can be transitioned to valid python so standard tools can be used. That's still a pipe dream for the time being.

jbrockmendel added a commit to jbrockmendel/pandas that referenced this pull request Sep 10, 2017
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants