-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Lock down kwargs in offsets signatures #17458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
5e276c9
Lock down kwargs in offsets signatures
jbrockmendel 0183e50
whatsnew note
jbrockmendel e33626e
Merge branch 'master' of https://github.com/pandas-dev/pandas into of…
jbrockmendel 1377df1
Merge branch 'master' of https://github.com/pandas-dev/pandas into of…
jbrockmendel ed78a4a
restrict YearOffset to month kwarg
jbrockmendel 36290d2
Restrict SemiMonthOffset kwargs to day_of_month
jbrockmendel 4443d6c
Lock down kwargs in FY5253 and FY5253Quarter
jbrockmendel 8cb6b66
lock down kwargs in BusinessDay, CustomBusinessMonthEnd
jbrockmendel fe7bb56
Lockdown kwargs in remaining DateOffset subclasses
jbrockmendel 3daab66
Briefer WhatsNew, add missing kwds attrs
jbrockmendel aefb68c
whitespace fixups
jbrockmendel 1e06d99
Move doc section to other api changes bullet point
jbrockmendel 7be31da
Merge branch 'master' into offset_sigs
jbrockmendel cd1f224
Add pickle tests for 0.19.2 and 0.20.3
jbrockmendel 97c896e
Merge branch 'offset_sigs' of https://github.com/jbrockmendel/pandas …
jbrockmendel e93de50
Merge branch 'master' of https://github.com/pandas-dev/pandas into of…
jbrockmendel 7426265
Merge branch 'master' of https://github.com/pandas-dev/pandas into of…
jbrockmendel aee75de
New version of test_pickle_v0_20_3
jbrockmendel cc5a71a
flake8 whitespace fixup
jbrockmendel 521a8d0
Merge branch 'master' of https://github.com/pandas-dev/pandas into of…
jbrockmendel 217a558
remove test per reviewer instruction
jbrockmendel 086b485
Add offsets with kwds to generate_legacy_storage_files
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,187 @@ | ||
| (dp0 | ||
| S'YearBegin' | ||
| p1 | ||
| ccopy_reg | ||
| _reconstructor | ||
| p2 | ||
| (cpandas.tseries.offsets | ||
| YearBegin | ||
| p3 | ||
| c__builtin__ | ||
| object | ||
| p4 | ||
| Ntp5 | ||
| Rp6 | ||
| (dp7 | ||
| S'normalize' | ||
| p8 | ||
| I00 | ||
| sS'kwds' | ||
| p9 | ||
| (dp10 | ||
| sS'n' | ||
| p11 | ||
| I1 | ||
| sS'_offset' | ||
| p12 | ||
| cdatetime | ||
| timedelta | ||
| p13 | ||
| (I1 | ||
| I0 | ||
| I0 | ||
| tp14 | ||
| Rp15 | ||
| sS'month' | ||
| p16 | ||
| I1 | ||
| sS'_use_relativedelta' | ||
| p17 | ||
| I00 | ||
| sbsS'Week' | ||
| p18 | ||
| g2 | ||
| (cpandas.tseries.offsets | ||
| Week | ||
| p19 | ||
| g4 | ||
| Ntp20 | ||
| Rp21 | ||
| (dp22 | ||
| g8 | ||
| I00 | ||
| sS'_inc' | ||
| p23 | ||
| g13 | ||
| (I7 | ||
| I0 | ||
| I0 | ||
| tp24 | ||
| Rp25 | ||
| sg9 | ||
| (dp26 | ||
| sS'weekday' | ||
| p27 | ||
| Nsg11 | ||
| I1 | ||
| sbsS'MonthBegin' | ||
| p28 | ||
| g2 | ||
| (cpandas.tseries.offsets | ||
| MonthBegin | ||
| p29 | ||
| g4 | ||
| Ntp30 | ||
| Rp31 | ||
| (dp32 | ||
| g8 | ||
| I00 | ||
| sg12 | ||
| g13 | ||
| (I1 | ||
| I0 | ||
| I0 | ||
| tp33 | ||
| Rp34 | ||
| sg17 | ||
| I00 | ||
| sg9 | ||
| (dp35 | ||
| sg11 | ||
| I1 | ||
| sbsS'Day' | ||
| p36 | ||
| g2 | ||
| (cpandas.tseries.offsets | ||
| Day | ||
| p37 | ||
| g4 | ||
| Ntp38 | ||
| Rp39 | ||
| (dp40 | ||
| g8 | ||
| I00 | ||
| sg12 | ||
| g13 | ||
| (I1 | ||
| I0 | ||
| I0 | ||
| tp41 | ||
| Rp42 | ||
| sg17 | ||
| I00 | ||
| sg9 | ||
| (dp43 | ||
| sg11 | ||
| I1 | ||
| sbsS'DateOffset' | ||
| p44 | ||
| g2 | ||
| (cpandas.tseries.offsets | ||
| DateOffset | ||
| p45 | ||
| g4 | ||
| Ntp46 | ||
| Rp47 | ||
| (dp48 | ||
| g8 | ||
| I00 | ||
| sg12 | ||
| g2 | ||
| (cdateutil.relativedelta | ||
| relativedelta | ||
| p49 | ||
| g4 | ||
| Ntp50 | ||
| Rp51 | ||
| (dp52 | ||
| S'_has_time' | ||
| p53 | ||
| I0 | ||
| sS'hour' | ||
| p54 | ||
| NsS'seconds' | ||
| p55 | ||
| I0 | ||
| sS'months' | ||
| p56 | ||
| I0 | ||
| sS'year' | ||
| p57 | ||
| NsS'days' | ||
| p58 | ||
| I0 | ||
| sS'years' | ||
| p59 | ||
| I1 | ||
| sS'hours' | ||
| p60 | ||
| I0 | ||
| sS'second' | ||
| p61 | ||
| NsS'microsecond' | ||
| p62 | ||
| Nsg16 | ||
| NsS'microseconds' | ||
| p63 | ||
| I0 | ||
| sS'leapdays' | ||
| p64 | ||
| I0 | ||
| sS'minutes' | ||
| p65 | ||
| I0 | ||
| sS'day' | ||
| p66 | ||
| NsS'minute' | ||
| p67 | ||
| Nsg27 | ||
| Nsbsg17 | ||
| I01 | ||
| sg9 | ||
| (dp68 | ||
| g59 | ||
| I1 | ||
| ssg11 | ||
| I1 | ||
| sbs. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,187 @@ | ||
| (dp0 | ||
| S'YearBegin' | ||
| p1 | ||
| ccopy_reg | ||
| _reconstructor | ||
| p2 | ||
| (cpandas.tseries.offsets | ||
| YearBegin | ||
| p3 | ||
| c__builtin__ | ||
| object | ||
| p4 | ||
| Ntp5 | ||
| Rp6 | ||
| (dp7 | ||
| S'normalize' | ||
| p8 | ||
| I00 | ||
| sS'kwds' | ||
| p9 | ||
| (dp10 | ||
| sS'n' | ||
| p11 | ||
| I1 | ||
| sS'_offset' | ||
| p12 | ||
| cdatetime | ||
| timedelta | ||
| p13 | ||
| (I1 | ||
| I0 | ||
| I0 | ||
| tp14 | ||
| Rp15 | ||
| sS'month' | ||
| p16 | ||
| I1 | ||
| sS'_use_relativedelta' | ||
| p17 | ||
| I00 | ||
| sbsS'Week' | ||
| p18 | ||
| g2 | ||
| (cpandas.tseries.offsets | ||
| Week | ||
| p19 | ||
| g4 | ||
| Ntp20 | ||
| Rp21 | ||
| (dp22 | ||
| g8 | ||
| I00 | ||
| sS'_inc' | ||
| p23 | ||
| g13 | ||
| (I7 | ||
| I0 | ||
| I0 | ||
| tp24 | ||
| Rp25 | ||
| sg9 | ||
| (dp26 | ||
| sS'weekday' | ||
| p27 | ||
| Nsg11 | ||
| I1 | ||
| sbsS'MonthBegin' | ||
| p28 | ||
| g2 | ||
| (cpandas.tseries.offsets | ||
| MonthBegin | ||
| p29 | ||
| g4 | ||
| Ntp30 | ||
| Rp31 | ||
| (dp32 | ||
| g8 | ||
| I00 | ||
| sg12 | ||
| g13 | ||
| (I1 | ||
| I0 | ||
| I0 | ||
| tp33 | ||
| Rp34 | ||
| sg17 | ||
| I00 | ||
| sg9 | ||
| (dp35 | ||
| sg11 | ||
| I1 | ||
| sbsS'Day' | ||
| p36 | ||
| g2 | ||
| (cpandas.tseries.offsets | ||
| Day | ||
| p37 | ||
| g4 | ||
| Ntp38 | ||
| Rp39 | ||
| (dp40 | ||
| g8 | ||
| I00 | ||
| sg12 | ||
| g13 | ||
| (I1 | ||
| I0 | ||
| I0 | ||
| tp41 | ||
| Rp42 | ||
| sg17 | ||
| I00 | ||
| sg9 | ||
| (dp43 | ||
| sg11 | ||
| I1 | ||
| sbsS'DateOffset' | ||
| p44 | ||
| g2 | ||
| (cpandas.tseries.offsets | ||
| DateOffset | ||
| p45 | ||
| g4 | ||
| Ntp46 | ||
| Rp47 | ||
| (dp48 | ||
| g8 | ||
| I00 | ||
| sg12 | ||
| g2 | ||
| (cdateutil.relativedelta | ||
| relativedelta | ||
| p49 | ||
| g4 | ||
| Ntp50 | ||
| Rp51 | ||
| (dp52 | ||
| S'_has_time' | ||
| p53 | ||
| I0 | ||
| sS'hour' | ||
| p54 | ||
| NsS'seconds' | ||
| p55 | ||
| I0 | ||
| sS'months' | ||
| p56 | ||
| I0 | ||
| sS'year' | ||
| p57 | ||
| NsS'days' | ||
| p58 | ||
| I0 | ||
| sS'years' | ||
| p59 | ||
| I1 | ||
| sS'hours' | ||
| p60 | ||
| I0 | ||
| sS'second' | ||
| p61 | ||
| NsS'microsecond' | ||
| p62 | ||
| Nsg16 | ||
| NsS'microseconds' | ||
| p63 | ||
| I0 | ||
| sS'leapdays' | ||
| p64 | ||
| I0 | ||
| sS'minutes' | ||
| p65 | ||
| I0 | ||
| sS'day' | ||
| p66 | ||
| NsS'minute' | ||
| p67 | ||
| Nsg27 | ||
| Nsbsg17 | ||
| I01 | ||
| sg9 | ||
| (dp68 | ||
| g59 | ||
| I1 | ||
| ssg11 | ||
| I1 | ||
| sbs. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not what i asked for at all
pls use the generate_legacy_data script
we have removed all of these ad hoc pickle things
we r not adding them back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You asked me to run a script that doesn't work, then to troubleshoot it until it does. I found existing tests and followed their example. Please cut me some darn slack.
test_pickle_v0_15_2andtest_pickle_compat_0_14_1might lead a naive reader (such as myself) to suspect otherwise.This sentence confuses me.
I have no interest in making changes to the non-functional generation script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well it works fine according to the instructions I gave and has been used for quite a while.
well if you look at what exists, the vast majority are in an organized format. The remaining ones should actually be converted to this format.
As you know pandas is a very large library. If things do not have process & procedure around them, then future generations will have pain. We have worked pretty hard (and you are contributing to this), to reduce technical debt.