Skip to content

cdef out dtype for _Timestamp._get_field #17457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

mroeschke
Copy link
Member

Follow-up to @jreback comment in #17377 to dtype the out variable in _get_field and get_named_field

Also, replaced value conversion in _get_start_end_field with _maybe_convert_value_to_local function created in #17377

@codecov
Copy link

codecov bot commented Sep 7, 2017

Codecov Report

Merging #17457 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17457      +/-   ##
==========================================
- Coverage   91.15%   91.14%   -0.02%     
==========================================
  Files         163      163              
  Lines       49591    49591              
==========================================
- Hits        45207    45198       -9     
- Misses       4384     4393       +9
Flag Coverage Δ
#multiple 88.92% <ø> (ø) ⬆️
#single 40.25% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.72% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20fee85...52a5f98. Read the comment docs.

@jreback jreback added this to the 0.21.0 milestone Sep 7, 2017
@jreback jreback added Compat pandas objects compatability with Numpy or Python functions Datetime Datetime data dtype labels Sep 7, 2017
@jreback jreback merged commit 8a8a4fd into pandas-dev:master Sep 7, 2017
@jreback
Copy link
Contributor

jreback commented Sep 7, 2017

thanks!

@mroeschke mroeschke deleted the cdef_out branch September 8, 2017 01:52
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Sep 10, 2017
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants