Use setdefault on kwds to standardize behavior #17443
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateOffset.kwds
does not behave consistently, see brief discussion here.This PR changes
kwds.get(name, default)
tokwds.setdefault(name, default)
in each of the__init__
methods intseries.offsets
. This ensures that explicitly passing the default value gives the same result as not using the kwarg.This also edits
Tick.__ne__
andTick.__eq__
to skip callingDateOffset.__ne__
andDateOffset.__eq__
, respectively, since these will always returnTrue
andFalse
, respectively. I make no claims as to the performance implications, but if a reader wanted to make an inference...git diff upstream/master -u -- "*.py" | flake8 --diff