-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: cleaned references to pandas v0.15 and v0.16 in docs #17442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: cleaned references to pandas v0.15 and v0.16 in docs #17442
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17442 +/- ##
==========================================
- Coverage 91.15% 91.14% -0.02%
==========================================
Files 163 163
Lines 49587 49587
==========================================
- Hits 45203 45194 -9
- Misses 4384 4393 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. some minor comments. ping when pushed / green.
doc/source/io.rst
Outdated
|
||
.. warning:: | ||
pandas requires ``PyTables`` >= 3.0.0. Stores written with prior versions of | ||
pandas / ``PyTables`` >= 2.3 are fully compatible (this was the previous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can take this out (about older PyTables)
doc/source/install.rst
Outdated
@@ -187,8 +187,7 @@ installed), make sure you have `pytest | |||
pandas version 0.18.0 | |||
numpy version 1.10.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iI would update the pandas & numpy version here as well (you can just change the text) to something more current
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually this is from an older nose run, can you fix up to show what pytest prints.
pls also add a whatsnew entry on Other Enhancements that docs are now updated to remove older references (and you can list the issue / PR's that were involved). |
43bcb38
to
f207219
Compare
ping @jreback |
thanks @topper-123 very nice series of changes! when docs are built (could be a while), see http://pandas-docs.github.io/pandas-docs-travis/ and if anything needs corrections pls push a PR. |
Ok, I'll go look in a few days. Yeah, these 3 commits have a net reduction in line count of ca. 330 lines, that's quite a bit of deadweight removed :-) |
Last round of cleanup of references to older pandas versions (here v0.15 and v0.16).
I'm not intending to go further up: v0.16.2 was released in june 2015, and allowing up to 2 years old references to be seen in the docs themselves is reasonable IMO. (but other may have a different view, so if there's a "demand" I could change the cut-off point, its not so much work).
See also #17420 and #17404.
I also removed a reference to python 3.4 in the
install.rst
. In the same document, I also "updated" the test section to show python3.6 (just a (very) minor signal that pandas is python 3 positive).