Skip to content

DOC: cleaned references to pandas v0.15 and v0.16 in docs #17442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

topper-123
Copy link
Contributor

Last round of cleanup of references to older pandas versions (here v0.15 and v0.16).

I'm not intending to go further up: v0.16.2 was released in june 2015, and allowing up to 2 years old references to be seen in the docs themselves is reasonable IMO. (but other may have a different view, so if there's a "demand" I could change the cut-off point, its not so much work).

See also #17420 and #17404.

I also removed a reference to python 3.4 in the install.rst. In the same document, I also "updated" the test section to show python3.6 (just a (very) minor signal that pandas is python 3 positive).

@codecov
Copy link

codecov bot commented Sep 5, 2017

Codecov Report

Merging #17442 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17442      +/-   ##
==========================================
- Coverage   91.15%   91.14%   -0.02%     
==========================================
  Files         163      163              
  Lines       49587    49587              
==========================================
- Hits        45203    45194       -9     
- Misses       4384     4393       +9
Flag Coverage Δ
#multiple 88.92% <ø> (ø) ⬆️
#single 40.25% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.72% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d457791...f207219. Read the comment docs.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. some minor comments. ping when pushed / green.


.. warning::
pandas requires ``PyTables`` >= 3.0.0. Stores written with prior versions of
pandas / ``PyTables`` >= 2.3 are fully compatible (this was the previous
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can take this out (about older PyTables)

@@ -187,8 +187,7 @@ installed), make sure you have `pytest
pandas version 0.18.0
numpy version 1.10.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iI would update the pandas & numpy version here as well (you can just change the text) to something more current

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this is from an older nose run, can you fix up to show what pytest prints.

@jreback jreback added the Docs label Sep 6, 2017
@jreback jreback added this to the 0.21.0 milestone Sep 6, 2017
@jreback
Copy link
Contributor

jreback commented Sep 6, 2017

pls also add a whatsnew entry on Other Enhancements that docs are now updated to remove older references (and you can list the issue / PR's that were involved).

@topper-123 topper-123 force-pushed the cleanup_references_to_v15-v16 branch from 43bcb38 to f207219 Compare September 6, 2017 16:40
@topper-123
Copy link
Contributor Author

ping @jreback

@jreback jreback merged commit 20fee85 into pandas-dev:master Sep 7, 2017
@jreback
Copy link
Contributor

jreback commented Sep 7, 2017

thanks @topper-123 very nice series of changes!

when docs are built (could be a while), see http://pandas-docs.github.io/pandas-docs-travis/

and if anything needs corrections pls push a PR.

@topper-123 topper-123 deleted the cleanup_references_to_v15-v16 branch September 7, 2017 01:58
@topper-123
Copy link
Contributor Author

Ok, I'll go look in a few days.

Yeah, these 3 commits have a net reduction in line count of ca. 330 lines, that's quite a bit of deadweight removed :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants