-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Plotting Timedelta on y-axis #16953 #17430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
84a8cc2
implemented fix for GH issue #16953
s-weigand f8dcb84
added tests for fix of issue #16953
s-weigand 23475c2
changed comments for git issue to pandas style GH#
s-weigand 9bb7389
changed linelength in tests, so all lines are less than 80 characters
s-weigand 13b60dc
added whatsnew entry
s-weigand eb6a110
swaped conversion and filtering of values, for plot to also work with…
s-weigand c438bb2
refomated code, so len(line) < 80
s-weigand e51a558
changed whatsnew with timedelta and datetime dtypes
s-weigand 84ad1d4
added support for datetimetz and extended tests
s-weigand 1ebfb13
added reason to pytest.mark.xfail
s-weigand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you take out the
_convert
and see, on what input does it fail?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yap i did, circleci fails at
tests.plotting.test_series.test_valid_object_plot
, since theSeries
is ofdtype == object
(s = Series(lrange(10), dtype=object)
, also see comment on your last requested changes).Also i think doing a general
data._convert
is more sturdy, than just calling in if theSeries
is of type object (which would be the minimal change for the test to pass).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I guess leave it in is ok. In general we don't automatically coerce object types (even if they are numbers) in other functions / places; we happen to do it in plotting for compat I think. Can you open a new issue for this to discuss (deprecating this).