Tslib unused #17402
Merged
Tslib unused #17402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17402 +/- ##
==========================================
- Coverage 91.03% 90.99% -0.05%
==========================================
Files 163 163
Lines 49580 49580
==========================================
- Hits 45137 45116 -21
- Misses 4443 4464 +21
Continue to review full report at Codecov.
|
sinhrks
added
Clean
Internals
|
Closes #17379 |
jreback
reviewed
Sep 1, 2017
| @@ -2622,8 +2622,6 @@ cdef class _Timedelta(timedelta): | |||
| int ndim | |||
|
|
|||
| if isinstance(other, _Timedelta): | |||
| if isinstance(other, _NaT): | |||
There was a problem hiding this comment.
why do you think this can be removed? are the NaT comparisons handled higher up (IOW they never hit this)? (I don't remember)
There was a problem hiding this comment.
See discussion in #17379. TLDR: _NaT does not subclass _Timedelta, so something very weird would have to be going on for this condition to be satisfied.
There was a problem hiding this comment.
In [1]: pd.Timedelta('1 day') > pd.NaT
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
<ipython-input-1-9550edbbc777> in <module>()
----> 1 pd.Timedelta('1 day') > pd.NaT
/Users/jreback/pandas/pandas/_libs/tslib.pyx in pandas._libs.tslib._Timedelta.__richcmp__ (pandas/_libs/tslib.c:47402)()
2653 elif op == Py_NE:
2654 return True
-> 2655 raise TypeError('Cannot compare type %r with type %r' %
2656 (type(self).__name__, type(other).__name__))
2657
TypeError: Cannot compare type 'Timedelta' with type 'NaTType'
In [2]: pd.Timedelta('1 day') == pd.NaT
Out[2]: False
right so this is ok
jowens
pushed a commit
to jowens/pandas
that referenced
this pull request
Sep 20, 2017
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
along with one repeated string and a case in
_Timedelta.__richcmp__that is not reachable.git diff upstream/master -u -- "*.py" | flake8 --diff