-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Separate parsing functions out from tslib #17363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
b0428ec
Separate parsing functions out from tslib
jbrockmendel b19a31e
flake8 whitespace fixup
jbrockmendel fa6def5
Address reviewer comments
jbrockmendel 2cd2ab6
Fix __doc__ cython complaint
jbrockmendel c765e26
lint fixup
jbrockmendel b3ca3c0
Reviewer comments; remove cython decorators
jbrockmendel e36f8be
kludge to move tslibs/parsing to make asv work
jbrockmendel c52c796
kludge to move tslibs/parsing to make asv work
jbrockmendel f5259ea
flake8 whitespace fixup
jbrockmendel d1765ab
Dummy commit to force CI
jbrockmendel ceac008
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel e3995be
Whitespace fixup
jbrockmendel 6db3e3c
rebase
jbrockmendel cfcb002
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel ff57861
Remove duplicate file
jbrockmendel 62cc7b0
Reviewer comments; import try_parse_xyz directly from tslibs.parsing
jbrockmendel 21046b3
flake8 fixup
jbrockmendel a5f8eca
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel 364a6b0
keep _DATEUTIL_LEXER_SPLIT private to tslibs.parsing
jbrockmendel f89d11e
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tslibs.parsing
does not haveNaT
in the namespace, so it returnsNAT_SENTINEL
in places where it otherwise would returnNaT
. That should be wrapped intslib
, will update.