BUG: Respect color argument in bar plot #17360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/source/whatsnew/v0.21.0.txt
Outdated
| @@ -374,6 +374,7 @@ I/O | |||
| Plotting | |||
| ^^^^^^^^ | |||
| - Bug in plotting methods using ``secondary_y`` and ``fontsize`` not setting secondary axis font size (:issue:`12565`) | |||
| - Bug in ``Series.plot.bar`` or ``DataFramee.plot.bar`` with ``y`` not respecting user-passed ``color`` (:issue:`16822`) | |||
TomAugspurger
force-pushed
the
barplot-color
branch
from
2dcf78c to
e02d8fd
Compare
This affect Series-like barplots with user-defined colors. We were always treating them as dataframe-like, with one color per column.
Codecov Report
@@ Coverage Diff @@
## master #17360 +/- ##
==========================================
- Coverage 91.25% 90.99% -0.26%
==========================================
Files 163 162 -1
Lines 49614 49570 -44
==========================================
- Hits 45274 45107 -167
- Misses 4340 4463 +123
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17360 +/- ##
==========================================
- Coverage 91.25% 91.23% -0.02%
==========================================
Files 163 163
Lines 49614 49617 +3
==========================================
- Hits 45274 45268 -6
- Misses 4340 4349 +9
Continue to review full report at Codecov.
|
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
This affect Series-like barplots with user-defined colors. We were always treating them as dataframe-like, with one color per column.
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
This affect Series-like barplots with user-defined colors. We were always treating them as dataframe-like, with one color per column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affect Series-like barplots with user-defined colors. We were always
treating them as dataframe-like, with one color per column.
closes #16822
This should go into 0.21.0, but if I have the time I'd like a put a more elegant solution in place.