DOC: skipna not an argument of drop_duplicates #1731
Closed
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From what I can tell, `skipna` keyword was both added and subsequently removed in pandas-dev#1244. However, the docstring for DataFrame.drop_duplicates still lists it as a parameter.
|
Thanks Paul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell,
skipnakeyword was both added and subsequentlyremoved in #1244. However, the docstring for DataFrame.drop_duplicates
still lists it as a parameter.
I remove this from the docs, so they accurately represent the code.
An alternative to this would be to put back the skipna functionality.
pinging @changhiskhan, since he was the one that worked on this.