Skip to content

Series replace #17226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Series replace #17226

wants to merge 5 commits into from

Conversation

RaghavBatra
Copy link

closes #13852

@RaghavBatra
Documentation added
34783df
@RaghavBatra
DOC: Updated pd.Series.replace
2b8c5ea 
Updated documentation so that it matched the functionality of
pd.Series.replace and NOT pd.DataFrame.replace
Fixes pandas-dev#13852
@RaghavBatra
Merge branch 'series-replace' of https://github.com/RaghavBatra/pandas …
7f90ebf 
…into series-replace
@pep8speaks
Copy link

pep8speaks commented Aug 11, 2017 •
edited
Loading

Hello @RaghavBatra! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on August 11, 2017 at 12:40 Hours UTC

@gfyoung gfyoung added the Docs label Aug 11, 2017
@gfyoung
Copy link
Member

gfyoung commented Aug 11, 2017

Can you undo the change to the IPython notebook? That is definitely not needed for this.

@codecov
Copy link

codecov bot commented Aug 11, 2017 •
edited
Loading

Codecov Report

Merging #17226 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17226      +/-   ##
==========================================
+ Coverage      91%   91.01%   +<.01%     
==========================================
  Files         162      162              
  Lines       49531    49531              
==========================================
+ Hits        45077    45080       +3     
+ Misses       4454     4451       -3
Flag Coverage Δ
#multiple 88.79% <ø> (+0.02%) ⬆️
#single 40.26% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 92.03% <ø> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.72% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.05% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06850a1...b92e3e9. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 11, 2017 •
edited
Loading

Codecov Report

Merging #17226 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17226      +/-   ##
==========================================
+ Coverage      91%   91.01%   +<.01%     
==========================================
  Files         162      162              
  Lines       49531    49531              
==========================================
+ Hits        45077    45080       +3     
+ Misses       4454     4451       -3
Flag Coverage Δ
#multiple 88.79% <ø> (+0.02%) ⬆️
#single 40.26% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 92.03% <ø> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.72% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.05% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06850a1...b92e3e9. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 11, 2017 •
edited
Loading

Codecov Report

Merging #17226 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17226      +/-   ##
==========================================
+ Coverage      91%   91.01%   +<.01%     
==========================================
  Files         162      162              
  Lines       49531    49531              
==========================================
+ Hits        45077    45080       +3     
+ Misses       4454     4451       -3
Flag Coverage Δ
#multiple 88.79% <ø> (+0.02%) ⬆️
#single 40.26% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 92.03% <ø> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.72% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.05% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06850a1...b92e3e9. Read the comment docs.

RaghavBatra added a commit to RaghavBatra/pandas that referenced this pull request Aug 11, 2017
@RaghavBatra
DOC: Updated Series.replace docs (pandas-dev#17226)
1b8034c
@RaghavBatra RaghavBatra mentioned this pull request Aug 11, 2017
Closed
@RaghavBatra
Copy link
Author

@gfyoung look here: #17230

@RaghavBatra RaghavBatra deleted the series-replace branch August 11, 2017 13:05
@jorisvandenbossche jorisvandenbossche added this to the No action milestone Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Series.replace and DataFrame.replace have same docstring?
4 participants
@RaghavBatra @pep8speaks @gfyoung @jorisvandenbossche