-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: add warning to append about inefficiency #16956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4618,10 +4618,10 @@ def append(self, other, ignore_index=False, verify_integrity=False): | |
the DataFrame's index, the order of the columns in the resulting | ||
DataFrame will be unchanged. | ||
|
||
Iteratively appending rows to a Dataframe can be more computationally | ||
intense than a single concatenate. A better solution is to append those | ||
rows to a list then concatenate the list with the original Dataframe | ||
all at once. | ||
Iteratively appending rows to a DataFrame can be more computationally | ||
intensive than a single concatenate. A better solution is to append | ||
those rows to a list and then concatenate the list with the original | ||
DataFrame all at once. | ||
|
||
See also | ||
-------- | ||
|
@@ -4653,6 +4653,32 @@ def append(self, other, ignore_index=False, verify_integrity=False): | |
2 5 6 | ||
3 7 8 | ||
|
||
The following, while not a recommended method for generating a | ||
DataFrame, illustrates how to efficiently generate a DataFrame from | ||
multiple data sources. | ||
|
||
Less efficient: | ||
>>> df = pd.DataFrame(columns=['A']) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a newline between "Less efficient" and ">>> df = ..." |
||
>>> for i in range(5): | ||
... df = df.append({'A'}: i}, ignore_index=True) | ||
>>> df | ||
A | ||
0 0 | ||
1 1 | ||
2 2 | ||
3 3 | ||
4 4 | ||
|
||
More efficient: | ||
>>> pd.concat([pd.DataFrame([i], columns=['A']) for i in range(5)], | ||
... ignore_index=True) | ||
A | ||
0 0 | ||
1 1 | ||
2 2 | ||
3 3 | ||
4 4 | ||
|
||
""" | ||
if isinstance(other, (Series, dict)): | ||
if isinstance(other, dict): | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1524,9 +1524,10 @@ def append(self, to_append, ignore_index=False, verify_integrity=False): | |
|
||
Notes | ||
----- | ||
Iteratively appending to a series can be more computationally intense | ||
Iteratively appending to a Series can be more computationally intensive | ||
than a single concatenate. A better solution is to append values to a | ||
list then concatenate the list with the original series all at once. | ||
list and then concatenate the list with the original series all at | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. series --> Series |
||
once. | ||
|
||
See also | ||
-------- | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't call this "efficient" since you just said it wasn't efficient.