Skip to content

STYLE: Ignore some pycodestyle errors #16944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TomAugspurger
Copy link
Contributor

xref #16933

@TomAugspurger TomAugspurger added this to the 0.21.0 milestone Jul 15, 2017
@TomAugspurger TomAugspurger added the Code Style Code style, linting, code_checks label Jul 15, 2017
@jreback
Copy link
Contributor

jreback commented Jul 15, 2017

no don't change these here
we don't actually want to change the linter itself
rather configure the pep8speaks (i will turn off for now)

@TomAugspurger
Copy link
Contributor Author

rather configure the pep8speaks (i will turn off for now)

You mean add a .pep8speaks.yml file?

@codecov
Copy link

codecov bot commented Jul 15, 2017

Codecov Report

Merging #16944 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16944      +/-   ##
==========================================
- Coverage   90.99%   90.98%   -0.02%     
==========================================
  Files         161      161              
  Lines       49306    49306              
==========================================
- Hits        44868    44859       -9     
- Misses       4438     4447       +9
Flag Coverage Δ
#multiple 88.75% <ø> (ø) ⬆️
#single 40.19% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.71% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad24759...c3dd534. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 15, 2017

Codecov Report

Merging #16944 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16944      +/-   ##
==========================================
- Coverage   90.99%   90.98%   -0.02%     
==========================================
  Files         161      161              
  Lines       49306    49306              
==========================================
- Hits        44868    44859       -9     
- Misses       4438     4447       +9
Flag Coverage Δ
#multiple 88.75% <ø> (ø) ⬆️
#single 40.19% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.71% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad24759...c3dd534. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 15, 2017

Codecov Report

Merging #16944 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16944      +/-   ##
==========================================
- Coverage   90.99%   90.98%   -0.02%     
==========================================
  Files         161      161              
  Lines       49306    49306              
==========================================
- Hits        44868    44859       -9     
- Misses       4438     4447       +9
Flag Coverage Δ
#multiple 88.75% <ø> (ø) ⬆️
#single 40.19% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.71% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad24759...c3dd534. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Jul 15, 2017

yeah I am going to push one now

@gfyoung
Copy link
Member

gfyoung commented Jul 15, 2017

@TomAugspurger : Closing in light of @jreback comment above.

@gfyoung gfyoung closed this Jul 15, 2017
@TomAugspurger TomAugspurger deleted the pcs branch October 27, 2017 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants