-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fixes for #16896(TimedeltaIndex indexing regression for strings) #16907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 7 commits into
pandas-dev:master
from
jdeschenes:is_timedelta64_dtype_fix
Jul 13, 2017
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e163de1
Fixes for #16896
2be2156
Comments from @jreback.
f65c018
fixed linting issues
21b5bd2
Changed location of the assert
dcb274d
Added an extra test
7d89c19
Added an extra test as per @shoyer recommendation.
3d36695
Changed assert location
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -199,12 +199,15 @@ def test_is_datetime64tz_dtype(): | |
|
||
def test_is_timedelta64_dtype(): | ||
assert not com.is_timedelta64_dtype(object) | ||
assert not com.is_timedelta64_dtype(None) | ||
assert not com.is_timedelta64_dtype([1, 2, 3]) | ||
assert not com.is_timedelta64_dtype(np.array([], dtype=np.datetime64)) | ||
assert com.is_timedelta64_dtype(np.timedelta64) | ||
assert com.is_timedelta64_dtype(pd.Series([], dtype="timedelta64[ns]")) | ||
|
||
assert not com.is_timedelta64_dtype('0 days') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. silly but can you group all of the assert not ones together (IIRC pattern is to have them first) |
||
assert not com.is_timedelta64_dtype("0 days 00:00:00") | ||
assert not com.is_timedelta64_dtype(["0 days 00:00:00"]) | ||
assert not com.is_timedelta64_dtype("NO DATE") | ||
|
||
|
||
def test_is_period_dtype(): | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also can you add:
com.is_timedelta64_dtype(pd.to_timedelta(['0 days', '1 days']))
IOW a TDI