Skip to content

MAINT: Give nice error message if xarray import fails #16664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Jun 11, 2017

Title is self-explanatory. Shouldn't xarray get the same nice error message as feather-format?

@codecov
Copy link

codecov bot commented Jun 11, 2017

Codecov Report

Merging #16664 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16664      +/-   ##
==========================================
- Coverage   90.93%   90.93%   -0.01%     
==========================================
  Files         161      161              
  Lines       49266    49269       +3     
==========================================
  Hits        44801    44801              
- Misses       4465     4468       +3
Flag Coverage Δ
#multiple 88.69% <50%> (-0.01%) ⬇️
#single 40.22% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 92.27% <50%> (-0.1%) ⬇️
pandas/core/indexes/datetimes.py 95.23% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceaf852...8925f00. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 11, 2017

Codecov Report

Merging #16664 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16664      +/-   ##
==========================================
- Coverage   90.93%   90.93%   -0.01%     
==========================================
  Files         161      161              
  Lines       49266    49269       +3     
==========================================
  Hits        44801    44801              
- Misses       4465     4468       +3
Flag Coverage Δ
#multiple 88.69% <50%> (-0.01%) ⬇️
#single 40.22% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 92.27% <50%> (-0.1%) ⬇️
pandas/core/indexes/datetimes.py 95.23% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceaf852...8925f00. Read the comment docs.

@jreback jreback added the Docs label Jun 11, 2017
@jreback jreback added this to the 0.21.0 milestone Jun 11, 2017
@jreback jreback merged commit 18a428d into pandas-dev:master Jun 11, 2017
@jreback
Copy link
Contributor

jreback commented Jun 11, 2017

thanks!

@gfyoung gfyoung deleted the xarray-import-failure branch June 11, 2017 19:47
stangirala pushed a commit to stangirala/pandas that referenced this pull request Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants