DOC: change doc build to python 3.6 #16545
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16545 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 161 161
Lines 51071 51071
=======================================
Hits 46348 46348
Misses 4723 4723
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16545 +/- ##
==========================================
+ Coverage 90.75% 90.75% +<.01%
==========================================
Files 161 161
Lines 51071 51072 +1
==========================================
+ Hits 46348 46349 +1
Misses 4723 4723
Continue to review full report at Codecov.
|
|
With these changes, the doctests now pass. |
|
Added |
|
@jorisvandenbossche lgtm. |
There was a problem hiding this comment.
The failure here was fixed by #16575
Merge if / when you're ready @jorisvandenbossche
|
I should have also brought this up in the other issue, are we OK with expanding our doctests? I think we should, as they make for better examples, and would have caught a couple things last time around. But they do feel a bit fragile (stuff like dtypes, ordering can break them). |
|
I am OK with that, and it's what I have been working (very slowly) towards (eg adding the imports in the conftest file to be able to run them, and on the docathon I let a few people corrects examples based on running the doctests). As long we don't see it as tests like the actual unit tests, but as testing that the example is correct, I think they are very useful. |
|
Yes, this is ready |
We should maybe make an overview somewhere of the different tricks to use to get the tests passing. And we should also check if we could do some of the directives (eg normalize whitespace) globally, so you don't need to add them in the actual example code |
* DOC: change doc build to python 3.6 * Remove pinning of pyqt to 4.x * Remove pinning of openpyxl * Add xsel to doc build for clipboard
* DOC: change doc build to python 3.6 * Remove pinning of pyqt to 4.x * Remove pinning of openpyxl * Add xsel to doc build for clipboard
see #16432