Skip to content

TST: Skip test_database_uri_string if pg8000 importable #16528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2017
Merged

TST: Skip test_database_uri_string if pg8000 importable #16528

merged 1 commit into from
Jun 1, 2017

Conversation

neirbowj
Copy link
Contributor

jreback
jreback reviewed May 29, 2017
View reviewed changes
pandas/tests/io/test_sql.py
@@ -938,6 +938,12 @@ def test_database_uri_string(self):

# using driver that will not be installed on Travis to trigger error
# in sqlalchemy.create_engine -> test passing of this error to user
Copy link
Contributor

@jreback jreback May 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you would need to do

pg8000 = pytest.importorskip('pg8000')  # noqa

you need to explicitly install this though in the requirements-2.7.pip (and other ones if needed)

cc @jorisvandenbossche

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neirbowj ahh I see what you posted on the issue. ok then your fix is fine (just need the noqa), and put an explanation of what is going on here.

jreback
jreback requested changes May 29, 2017
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually how did this come up? reading the comments suggest that we don't want to have this driver installed at all (we are testing an error when sqlalchemy is installed but not a specific driver).

@jreback jreback added the IO SQL to_sql, read_sql, read_sql_query label May 29, 2017
@codecov
Copy link

codecov bot commented May 29, 2017

Codecov Report

Merging #16528 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16528      +/-   ##
==========================================
- Coverage   90.79%   90.79%   -0.01%     
==========================================
  Files         161      161              
  Lines       51063    51063              
==========================================
- Hits        46365    46364       -1     
- Misses       4698     4699       +1
Flag Coverage Δ
#multiple 88.63% <ø> (-0.01%) ⬇️
#single 40.15% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/datetimes.py 95.23% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e60dc4c...e22541b. Read the comment docs.

@codecov
Copy link

codecov bot commented May 29, 2017 •
edited
Loading

Codecov Report

Merging #16528 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16528   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files         161      161           
  Lines       51063    51063           
=======================================
  Hits        46365    46365           
  Misses       4698     4698
Flag Coverage Δ
#multiple 88.63% <ø> (ø) ⬆️
#single 40.15% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e60dc4c...e22541b. Read the comment docs.

@jreback jreback added this to the 0.21.0 milestone May 31, 2017
@jreback
Copy link
Contributor

jreback commented May 31, 2017

@jorisvandenbossche ok?

@TomAugspurger
Copy link
Contributor

This looks good, thanks.

@TomAugspurger TomAugspurger merged commit a7760e3 into pandas-dev:master Jun 1, 2017
@jorisvandenbossche
Copy link
Member

Yes, perfect! Thanks @neirbowj

Kiv pushed a commit to Kiv/pandas that referenced this pull request Jun 11, 2017
@neirbowj @Kiv
TST: Skip test_database_uri_string if pg8000 importable (pandas-dev#1…
79beeb6 
…6528)
stangirala pushed a commit to stangirala/pandas that referenced this pull request Jun 11, 2017
@neirbowj @stangirala
TST: Skip test_database_uri_string if pg8000 importable (pandas-dev#1…
6c4b7ff 
…6528)
@neirbowj neirbowj deleted the test_sql_pg8000 branch February 11, 2018 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

TestSQLApi/TestSQLApiConn::test_database_uri_string errors if pg8000 is installed
4 participants
@neirbowj @jreback @TomAugspurger @jorisvandenbossche