ENH: Support inplace clip (#15388) #16462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
May 23, 2017
| @@ -4149,6 +4153,8 @@ def clip(self, lower=None, upper=None, axis=None, *args, **kwargs): | |||
| upper : float or array_like, default None | |||
| axis : int or string axis name, optional | |||
| Align object with lower and upper along the given axis. | |||
| inplace : boolean, default False | |||
| Whether to perform the operation in place on the data | |||
jreback
reviewed
May 23, 2017
| @@ -4220,6 +4231,8 @@ def clip_upper(self, threshold, axis=None): | |||
| threshold : float or array_like | |||
| axis : int or string axis name, optional | |||
| Align object with threshold along the given axis. | |||
| inplace : boolean, default False | |||
| Whether to perform the operation in place on the data | |||
jreback
reviewed
May 23, 2017
| @@ -4247,6 +4262,8 @@ def clip_lower(self, threshold, axis=None): | |||
| threshold : float or array_like | |||
| axis : int or string axis name, optional | |||
| Align object with threshold along the given axis. | |||
| inplace : boolean, default False | |||
| Whether to perform the operation in place on the data | |||
jreback
approved these changes
May 23, 2017
pandas/tests/frame/test_analytics.py
Outdated
| clipped_df = df.clip(lb, ub, axis=0) | ||
| original = df.copy() | ||
|
|
||
| if inplace: |
There was a problem hiding this comment.
you can just do
clipped_df = df.clip(lb, ub, axis=0, inplace=inplace)
if inplace:
clipped_df = df
|
note this doesn't offer any perf benefit (actually doing this is a bit tricky), but ok. |
jreback
added
Enhancement
Numeric Operations
guygoldberg
force-pushed
the
15388-inplace-clip
branch
from
b3488d4 to
2e7f8c1
Compare
Codecov Report
@@ Coverage Diff @@
## master #16462 +/- ##
=========================================
Coverage ? 90.42%
=========================================
Files ? 161
Lines ? 51036
Branches ? 0
=========================================
Hits ? 46151
Misses ? 4885
Partials ? 0
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16462 +/- ##
==========================================
+ Coverage 90.39% 90.42% +0.02%
==========================================
Files 161 161
Lines 51036 51045 +9
==========================================
+ Hits 46136 46159 +23
+ Misses 4900 4886 -14
Continue to review full report at Codecov.
|
guygoldberg
force-pushed
the
15388-inplace-clip
branch
from
2e7f8c1 to
f6fa959
Compare
|
@jreback, thanks. I fixed all of the comments and pushed to my branch. |
jreback
approved these changes
May 24, 2017
doc/source/whatsnew/v0.21.0.txt
Outdated
| @@ -35,6 +35,7 @@ Other Enhancements | |||
| - ``RangeIndex.append`` now returns a ``RangeIndex`` object when possible (:issue:`16212`) | |||
| - :func:`to_pickle` has gained a protocol parameter (:issue:`16252`). By default, this parameter is set to `HIGHEST_PROTOCOL <https://docs.python.org/3/library/pickle.html#data-stream-format>`__ | |||
| - :func:`api.types.infer_dtype` now infers decimals. (:issue: `15690`) | |||
| - :func:`clip` now supports inplace trimming. (:issue: `15388`) | |||
There was a problem hiding this comment.
no, DataFrame.clip() and Series.cip() have gained an inplace argument.
pandas/tests/frame/test_analytics.py
Outdated
| clipped_df = df.clip(lb, ub, axis=0) | ||
| original = df.copy() | ||
|
|
||
|
|
guygoldberg
force-pushed
the
15388-inplace-clip
branch
from
de16f27 to
58dd405
Compare
guygoldberg
force-pushed
the
15388-inplace-clip
branch
from
58dd405 to
62ee43b
Compare
|
thanks! |
stangirala
pushed a commit
to stangirala/pandas
that referenced
this pull request
Jun 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master --name-only -- '*.py' | flake8 --diff